Apply most of recommended project changes (OS X)

diff --git a/Transmission.xcodeproj/project.pbxproj b/Transmission.xcodeproj/project.pbxproj
index 6839b131cd0173dd068315e139e1e192cbd58c89..35e1f767b523bd4e816137025b666fbbe82bb5ba 100644 (file)
--- a/Transmission.xcodeproj/project.pbxproj
+++ b/Transmission.xcodeproj/project.pbxproj
@@ -160,7 +160,6 @@
                A23547E311CD0B090046EAE6 /* cache.h in Headers */ = {isa = PBXBuildFile; fileRef = A23547E111CD0B090046EAE6 /* cache.h */; };
                A2385DD40BFE06C800B24EF6 /* DragOverlayWindow.m in Sources */ = {isa = PBXBuildFile; fileRef = A2385DD20BFE06C800B24EF6 /* DragOverlayWindow.m */; };
                A23D5DA71320570800E422BA /* CleanupTemplate.png in Resources */ = {isa = PBXBuildFile; fileRef = A23D5DA61320570800E422BA /* CleanupTemplate.png */; };
-               A23E75D115FC1A2500E91223 /* style.css in Resources */ = {isa = PBXBuildFile; fileRef = A29304EC15D7465100B1F726 /* style.css */; };
                A23F29A1132A447400E9A83B /* announcer-common.h in Headers */ = {isa = PBXBuildFile; fileRef = A23F299F132A447400E9A83B /* announcer-common.h */; };
                A23F29A2132A447400E9A83B /* announcer-http.c in Sources */ = {isa = PBXBuildFile; fileRef = A23F29A0132A447400E9A83B /* announcer-http.c */; };
                A23F4FF20D1D98AD002FCB97 /* PrefsWindow.xib in Resources */ = {isa = PBXBuildFile; fileRef = A23F4FF00D1D98AD002FCB97 /* PrefsWindow.xib */; };
@@ -298,7 +297,6 @@
                A2D77453154CC72B00A62B93 /* WebSeedTableView.m in Sources */ = {isa = PBXBuildFile; fileRef = A2D77450154CC25700A62B93 /* WebSeedTableView.m */; };
                A2D8CFBA15F82DFA0056E93D /* NSApplicationAdditions.m in Sources */ = {isa = PBXBuildFile; fileRef = A29D84031049C25600D1987A /* NSApplicationAdditions.m */; };
                A2D8CFBB15F82E030056E93D /* NSStringAdditions.m in Sources */ = {isa = PBXBuildFile; fileRef = 4DE5CC9C0980656F00BE280E /* NSStringAdditions.m */; };
-               A2D8CFC015FA177A0056E93D /* style.css in Resources */ = {isa = PBXBuildFile; fileRef = A29304EC15D7465100B1F726 /* style.css */; };
                A2DA362A0CBC674900C2ED41 /* InfoActivity.png in Resources */ = {isa = PBXBuildFile; fileRef = A2DA36270CBC674900C2ED41 /* InfoActivity.png */; };
                A2DA362B0CBC674900C2ED41 /* InfoFiles.png in Resources */ = {isa = PBXBuildFile; fileRef = A2DA36280CBC674900C2ED41 /* InfoFiles.png */; };
                A2DA362C0CBC674900C2ED41 /* InfoPeers.png in Resources */ = {isa = PBXBuildFile; fileRef = A2DA36290CBC674900C2ED41 /* InfoPeers.png */; };
@@ -2684,8 +2682,6 @@
                                A2F35BC815C5A0A100EBF632 /* InfoPlist.strings in Resources */,
                                A29304ED15D7465100B1F726 /* style.css in Resources */,
                                A242AD9315F05D23002B3A6C /* Localizable.strings in Resources */,
-                               A2D8CFC015FA177A0056E93D /* style.css in Resources */,
-                               A23E75D115FC1A2500E91223 /* style.css in Resources */,
                        );
                        runOnlyForDeploymentPostprocessing = 0;
                };
@@ -3397,15 +3393,24 @@
                0053D3DA0C86774200545606 /* Debug */ = {
                        isa = XCBuildConfiguration;
                        buildSettings = {
-                               ARCHS = "$(NATIVE_ARCH_ACTUAL)";
+                               CLANG_WARN_BOOL_CONVERSION = YES;
+                               CLANG_WARN_CONSTANT_CONVERSION = YES;
+                               CLANG_WARN_EMPTY_BODY = YES;
+                               CLANG_WARN_ENUM_CONVERSION = YES;
+                               CLANG_WARN_INT_CONVERSION = YES;
+                               CLANG_WARN_UNREACHABLE_CODE = YES;
                                CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
+                               COMBINE_HIDPI_IMAGES = YES;
                                COPY_PHASE_STRIP = NO;
                                DEAD_CODE_STRIPPING = NO;
                                DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
+                               ENABLE_STRICT_OBJC_MSGSEND = YES;
+                               ENABLE_TESTABILITY = YES;
                                GCC_DYNAMIC_NO_PIC = YES;
                                GCC_ENABLE_PASCAL_STRINGS = NO;
                                GCC_GENERATE_DEBUGGING_SYMBOLS = YES;
                                GCC_INCREASE_PRECOMPILED_HEADER_SHARING = YES;
+                               GCC_NO_COMMON_BLOCKS = YES;
                                GCC_OPTIMIZATION_LEVEL = 0;
                                GCC_PRECOMPILE_PREFIX_HEADER = YES;
                                GCC_PREPROCESSOR_DEFINITIONS = (
@@ -3414,8 +3419,11 @@
                                );
                                GCC_UNROLL_LOOPS = YES;
                                GCC_VERSION = com.apple.compilers.llvm.clang.1_0;
+                               GCC_WARN_ABOUT_RETURN_TYPE = YES;
                                GCC_WARN_INITIALIZER_NOT_FULLY_BRACKETED = YES;
+                               GCC_WARN_UNDECLARED_SELECTOR = YES;
                                GCC_WARN_UNINITIALIZED_AUTOS = YES;
+                               GCC_WARN_UNUSED_FUNCTION = YES;
                                GCC_WARN_UNUSED_VARIABLE = YES;
                                HEADER_SEARCH_PATHS = (
                                        "third-party/curl/include",
@@ -3521,15 +3529,23 @@
                4DF0C59D089918A300DD8943 /* Release */ = {
                        isa = XCBuildConfiguration;
                        buildSettings = {
-                               ARCHS = "$(ARCHS_STANDARD_32_64_BIT)";
+                               CLANG_WARN_BOOL_CONVERSION = YES;
+                               CLANG_WARN_CONSTANT_CONVERSION = YES;
+                               CLANG_WARN_EMPTY_BODY = YES;
+                               CLANG_WARN_ENUM_CONVERSION = YES;
+                               CLANG_WARN_INT_CONVERSION = YES;
+                               CLANG_WARN_UNREACHABLE_CODE = YES;
                                CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
+                               COMBINE_HIDPI_IMAGES = YES;
                                DEAD_CODE_STRIPPING = YES;
                                DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
                                DEPLOYMENT_POSTPROCESSING = YES;
+                               ENABLE_STRICT_OBJC_MSGSEND = YES;
                                GCC_DYNAMIC_NO_PIC = YES;
                                GCC_ENABLE_PASCAL_STRINGS = NO;
                                GCC_GENERATE_DEBUGGING_SYMBOLS = YES;
                                GCC_INCREASE_PRECOMPILED_HEADER_SHARING = YES;
+                               GCC_NO_COMMON_BLOCKS = YES;
                                GCC_PRECOMPILE_PREFIX_HEADER = YES;
                                GCC_PREPROCESSOR_DEFINITIONS = (
                                        NS_BLOCK_ASSERTIONS,
@@ -3538,8 +3554,11 @@
                                );
                                GCC_UNROLL_LOOPS = YES;
                                GCC_VERSION = com.apple.compilers.llvm.clang.1_0;
+                               GCC_WARN_ABOUT_RETURN_TYPE = YES;
                                GCC_WARN_INITIALIZER_NOT_FULLY_BRACKETED = YES;
+                               GCC_WARN_UNDECLARED_SELECTOR = YES;
                                GCC_WARN_UNINITIALIZED_AUTOS = YES;
+                               GCC_WARN_UNUSED_FUNCTION = YES;
                                GCC_WARN_UNUSED_VARIABLE = YES;
                                HEADER_SEARCH_PATHS = (
                                        "third-party/curl/include",
@@ -3586,16 +3605,25 @@
                A250CFEB0CDA19680068B4B6 /* Release - Debug */ = {
                        isa = XCBuildConfiguration;
                        buildSettings = {
-                               ARCHS = "$(ARCHS_STANDARD_32_64_BIT)";
+                               CLANG_WARN_BOOL_CONVERSION = YES;
+                               CLANG_WARN_CONSTANT_CONVERSION = YES;
+                               CLANG_WARN_EMPTY_BODY = YES;
+                               CLANG_WARN_ENUM_CONVERSION = YES;
+                               CLANG_WARN_INT_CONVERSION = YES;
+                               CLANG_WARN_UNREACHABLE_CODE = YES;
                                CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
+                               COMBINE_HIDPI_IMAGES = YES;
                                COPY_PHASE_STRIP = NO;
                                DEAD_CODE_STRIPPING = NO;
                                DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
                                DEPLOYMENT_POSTPROCESSING = YES;
+                               ENABLE_STRICT_OBJC_MSGSEND = YES;
+                               ENABLE_TESTABILITY = YES;
                                GCC_DYNAMIC_NO_PIC = YES;
                                GCC_ENABLE_PASCAL_STRINGS = NO;
                                GCC_GENERATE_DEBUGGING_SYMBOLS = YES;
                                GCC_INCREASE_PRECOMPILED_HEADER_SHARING = YES;
+                               GCC_NO_COMMON_BLOCKS = YES;
                                GCC_PRECOMPILE_PREFIX_HEADER = YES;
                                GCC_PREPROCESSOR_DEFINITIONS = (
                                        BUILD_MAC_CLIENT,
@@ -3603,8 +3631,11 @@
                                );
                                GCC_UNROLL_LOOPS = YES;
                                GCC_VERSION = com.apple.compilers.llvm.clang.1_0;
+                               GCC_WARN_ABOUT_RETURN_TYPE = YES;
                                GCC_WARN_INITIALIZER_NOT_FULLY_BRACKETED = YES;
+                               GCC_WARN_UNDECLARED_SELECTOR = YES;
                                GCC_WARN_UNINITIALIZED_AUTOS = YES;
+                               GCC_WARN_UNUSED_FUNCTION = YES;
                                GCC_WARN_UNUSED_VARIABLE = YES;
                                HEADER_SEARCH_PATHS = (
                                        "third-party/curl/include",
@@ -3622,6 +3653,7 @@
                                        "third-party/openssl/lib",
                                );
                                MACOSX_DEPLOYMENT_TARGET = 10.7;
+                               ONLY_ACTIVE_ARCH = YES;
                                SDKROOT = macosx;
                                STRIP_INSTALLED_PRODUCT = NO;
                        };