top: trade just 1 'Ctrl' bottom window key association

I grew tired of inadvertently causing a premature exit
from top when all I wanted was to review some process'
environment variables. That 'V' key was just too close
to the 'C' key so the '^V' attempt became one of '^C'.

Well, not any more. Should a user wish to see a task's
environment, it will now require the '^N' combination.

[ it also now places G/U & N/K on a similar diagonal ]

Along the way, lower case Ctrl key combinations on the
help screen were all changed into upper case versions.

Signed-off-by: Jim Warner <james.warner@comcast.net>

diff --git a/top/top.c b/top/top.c
index 77488b88d2bf967d49e9674b6e74a2554726bb3b..a330a775d2a4b6dc2280cdca98558c33e3ec0ef7 100644 (file)
--- a/top/top.c
+++ b/top/top.c
@@ -5321,6 +5321,19 @@ static void keys_global (int ch) {
             Fieldstab[eu_GENERIC].item = PIDS_extra;
          }
          break;
+      case kbd_CtrlN:
+         def = PID_VAL(EU_PID, s_int, w->ppt[w->begtask]);
+         // if already targeted, assume user wants to turn it off ...
+         if (Tagged_task && Fieldstab[eu_GENERIC].item == PIDS_ENVIRON) {
+            TAGGED_TOSS;
+         } else {
+            Tagged_task = def;
+            Tagged_enum = eu_GENERIC;
+            Tagged_name = "environment";
+            Tagged_func = wins_tag_generic;
+            Fieldstab[eu_GENERIC].item = PIDS_ENVIRON;
+         }
+         break;
       case kbd_CtrlR:
          if (Secure_mode)
             show_msg(N_txt(NOT_onsecure_txt));
@@ -5360,19 +5373,6 @@ static void keys_global (int ch) {
             Fieldstab[eu_GENERIC].item = PIDS_SUPGROUPS;
          }
          break;
-      case kbd_CtrlV:
-         def = PID_VAL(EU_PID, s_int, w->ppt[w->begtask]);
-         // if already targeted, assume user wants to turn it off ...
-         if (Tagged_task && Fieldstab[eu_GENERIC].item == PIDS_ENVIRON) {
-            TAGGED_TOSS;
-         } else {
-            Tagged_task = def;
-            Tagged_enum = eu_GENERIC;
-            Tagged_name = "environment";
-            Tagged_func = wins_tag_generic;
-            Fieldstab[eu_GENERIC].item = PIDS_ENVIRON;
-         }
-         break;
       case kbd_ENTER:             // these two have the effect of waking us
       case kbd_SPACE:             // from 'pselect', refreshing the display
          break;                   // and updating any hot-plugged resources
@@ -6213,7 +6213,7 @@ static void do_key (int ch) {
       { keys_global,
          { '?', 'B', 'd', 'E', 'e', 'f', 'g', 'H', 'h'
          , 'I', 'k', 'r', 's', 'X', 'Y', 'Z', '0'
-         , kbd_CtrlE, kbd_CtrlG, kbd_CtrlK, kbd_CtrlR, kbd_CtrlU, kbd_CtrlV
+         , kbd_CtrlE, kbd_CtrlG, kbd_CtrlK, kbd_CtrlN, kbd_CtrlR, kbd_CtrlU
          , kbd_ENTER, kbd_SPACE, '\0' } },
       { keys_summary,
          { '!', '1', '2', '3', '4', 'C', 'l', 'm', 't', '\0' } },

diff --git a/top/top.h b/top/top.h
index 36f5f7d92b73d3c2669cb85632edec0996c378f9..a77633557452787438230d3db24631770711f8ca 100644 (file)
--- a/top/top.h
+++ b/top/top.h
@@ -173,10 +173,10 @@ char *strcasestr(const char *haystack, const char *needle);
 #define kbd_CtrlE  '\005'
 #define kbd_CtrlG  '\007'
 #define kbd_CtrlK  '\013'
+#define kbd_CtrlN  '\016'
 #define kbd_CtrlO  '\017'
 #define kbd_CtrlR  '\022'
 #define kbd_CtrlU  '\025'
-#define kbd_CtrlV  '\026'
 
         /* Special value in Pseudo_row to force an additional procs refresh
            -- used at startup and for task/thread mode transitions */

diff --git a/top/top_nls.c b/top/top_nls.c
index 03ddedc545437b3af6c0884ff392d4a2bd38a8c2..30825d09418ae72cad875fec0b5d5193fe0c0f17 100644 (file)
--- a/top/top_nls.c
+++ b/top/top_nls.c
@@ -651,8 +651,8 @@ static void build_uniq_nlstab (void) {
       "  V,v,F   . Toggle: '~1V~2' forest view; '~1v~2' hide/show children; '~1F~2' keep focused\n"
       "\n"
       "%s"
-      "  ^G,K,U,V  View: ctl groups ~1^g~2; cmdline ~1^k~2; supp groups ~1^u~2; environment ~1^v~2\n"
-      "  W,Y,!,^E  Write cfg '~1W~2'; Inspect '~1Y~2'; Combine Cpus '~1!~2'; Scale time ~1^e~2'\n"
+      "  ^G,K,N,U  View: ctl groups ~1^G~2; cmdline ~1^K~2; environment ~1^N~2; supp groups ~1^U~2\n"
+      "  W,Y,!,^E  Write cfg '~1W~2'; Inspect '~1Y~2'; Combine Cpus '~1!~2'; Scale time ~1^E~2'\n"
       "  q         Quit\n"
       "          ( commands shown with '.' require a ~1visible~2 task display ~1window~2 ) \n"
       "Press '~1h~2' or '~1?~2' for help with ~1Windows~2,\n"