]> granicus.if.org Git - llvm/commitdiff
llvm-undname: Fix oss-fuzz-foudn crash-on-invalid with incomplete special table nodes
authorNico Weber <nicolasweber@gmx.de>
Sun, 14 Apr 2019 23:32:37 +0000 (23:32 +0000)
committerNico Weber <nicolasweber@gmx.de>
Sun, 14 Apr 2019 23:32:37 +0000 (23:32 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@358367 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Demangle/MicrosoftDemangle.cpp
test/Demangle/invalid-manglings.test

index 882913a98632fbc55972852fc401c69ceb47a6df..2b41c0037f9b183ad60d45d000d9a8fcd80babc1 100644 (file)
@@ -276,6 +276,10 @@ Demangler::demangleSpecialTableSymbolNode(StringView &MangledName,
   SpecialTableSymbolNode *STSN = Arena.alloc<SpecialTableSymbolNode>();
   STSN->Name = QN;
   bool IsMember = false;
+  if (MangledName.empty()) {
+    Error = true;
+    return nullptr;
+  }
   char Front = MangledName.popFront();
   if (Front != '6' && Front != '7') {
     Error = true;
index eb22d1e0a4cbdf388b57a4fdbaf08a8e71878393..869d63a274f6e0569e3620030f46e433a4bd60dc 100644 (file)
 ; CHECK-EMPTY:
 ; CHECK-NEXT: ?foo@?$?_
 ; CHECK-NEXT: error: Invalid mangled name
+
+??_R4
+; CHECK-EMPTY:
+; CHECK-NEXT: ??_R4
+; CHECK-NEXT: error: Invalid mangled name
+
+??_R4foo@@
+; CHECK-EMPTY:
+; CHECK-NEXT: ??_R4foo@@
+; CHECK-NEXT: error: Invalid mangled name