Make sure we always compile with BOOST_CB_ENABLE_DEBUG set to 0

diff --git a/pdns/Makefile.am b/pdns/Makefile.am
index 4f71e11908463761c38db28e64f309078e3b02bd..43830c8f5c012e808acb1b2ffaf6200c7fbc0572 100644 (file)
--- a/pdns/Makefile.am
+++ b/pdns/Makefile.am
@@ -160,6 +160,7 @@ pdns_server_SOURCES = \
        bindlexer.l \
        bindparser.cc \
        cachecleaner.hh \
+       circular_buffer.hh \
        comment.hh \
        common_startup.cc common_startup.hh \
        communicator.cc communicator.hh \
@@ -296,6 +297,7 @@ pdnsutil_SOURCES = \
        bindlexer.l \
        bindparser.yy \
        cachecleaner.hh \
+       circular_buffer.hh \
        dbdnsseckeeper.cc \
        dnsbackend.cc \
        dns.cc \

diff --git a/pdns/circular_buffer.hh b/pdns/circular_buffer.hh
new file mode 100644 (file)
index 0000000..f9607f8
--- /dev/null
+++ b/pdns/circular_buffer.hh
@@ -0,0 +1,34 @@
+/*
+ * This file is part of PowerDNS or dnsdist.
+ * Copyright -- PowerDNS.COM B.V. and its contributors
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of version 2 of the GNU General Public License as
+ * published by the Free Software Foundation.
+ *
+ * In addition, for the avoidance of any doubt, permission is granted to
+ * link this program with OpenSSL and to (re)distribute the binaries
+ * produced as the result of such linking.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+ */
+#pragma once
+
+#ifndef BOOST_CB_ENABLE_DEBUG
+#define BOOST_CB_ENABLE_DEBUG 0
+#endif
+
+#if BOOST_CB_ENABLE_DEBUG
+// https://github.com/boostorg/circular_buffer/pull/9
+// https://svn.boost.org/trac10/ticket/6277
+#error Building with BOOST_CB_ENABLE_DEBUG prevents accessing a boost::circular_buffer from two threads at once
+#endif /* BOOST_CB_ENABLE_DEBUG */
+
+#include <boost/circular_buffer.hpp>

diff --git a/pdns/dnsdist-rings.hh b/pdns/dnsdist-rings.hh
index a773ed6e96ba2e1172405be87f0def959e6fb070..8a3e089d5cfdad3cd1ccc936c2bfef074f33ba7c 100644 (file)
--- a/pdns/dnsdist-rings.hh
+++ b/pdns/dnsdist-rings.hh
@@ -25,9 +25,9 @@
 #include <time.h>
 #include <unordered_map>
 
-#include <boost/circular_buffer.hpp>
 #include <boost/variant.hpp>
 
+#include "circular_buffer.hh"
 #include "dnsname.hh"
 #include "iputils.hh"
 

diff --git a/pdns/dnsdist.hh b/pdns/dnsdist.hh
index a96a87b439d17ff920bc7e65eb0ae8d642b9eb99..389d9109991ca401dc4e250fb4489f0d60d17926 100644 (file)
--- a/pdns/dnsdist.hh
+++ b/pdns/dnsdist.hh
@@ -31,11 +31,11 @@
 #include <unistd.h>
 #include <unordered_map>
 
-#include <boost/circular_buffer.hpp>
 #include <boost/variant.hpp>
 
 #include "bpf-filter.hh"
 #include "capabilities.hh"
+#include "circular_buffer.hh"
 #include "dnscrypt.hh"
 #include "dnsdist-cache.hh"
 #include "dnsdist-dynbpf.hh"

diff --git a/pdns/dnsdistdist/Makefile.am b/pdns/dnsdistdist/Makefile.am
index 2112afa53e4ebdb14dac3a8ccea60cbd1774493e..ae22d8d95120b45347a1e635c73fc6f92a905482 100644 (file)
--- a/pdns/dnsdistdist/Makefile.am
+++ b/pdns/dnsdistdist/Makefile.am
@@ -103,6 +103,7 @@ dnsdist_SOURCES = \
        bpf-filter.cc bpf-filter.hh \
        cachecleaner.hh \
        capabilities.cc capabilities.hh \
+       circular_buffer.hh \
        dns.cc dns.hh \
        dnscrypt.cc dnscrypt.hh \
        dnsdist.cc dnsdist.hh \
@@ -253,9 +254,11 @@ testrunner_SOURCES = \
        test-iputils_hh.cc \
        test-mplexer.cc \
        cachecleaner.hh \
+       circular_buffer.hh \
        dnsdist.hh \
        dnsdist-cache.cc dnsdist-cache.hh \
        dnsdist-ecs.cc dnsdist-ecs.hh \
+       dnsdist-rings.hh \
        dnsdist-xpf.cc dnsdist-xpf.hh \
        dnscrypt.cc dnscrypt.hh \
        dnslabeltext.cc \

diff --git a/pdns/dnsdistdist/circular_buffer.hh b/pdns/dnsdistdist/circular_buffer.hh
new file mode 120000 (symlink)
index 0000000..b0b7895
--- /dev/null
+++ b/pdns/dnsdistdist/circular_buffer.hh
@@ -0,0 +1 @@
+../circular_buffer.hh
\ No newline at end of file

diff --git a/pdns/dnsdistdist/tcpiohandler.cc b/pdns/dnsdistdist/tcpiohandler.cc
index 5591ecd9c3e8732614072ef7499fa6b138149b39..5e506e24d5ec293582b3a63cbce0812297f9e914 100644 (file)
--- a/pdns/dnsdistdist/tcpiohandler.cc
+++ b/pdns/dnsdistdist/tcpiohandler.cc
@@ -1,6 +1,7 @@
 #include <fstream>
 
 #include "config.h"
+#include "circular_buffer.hh"
 #include "dolog.hh"
 #include "iputils.hh"
 #include "lock.hh"
@@ -17,8 +18,6 @@
 #include <openssl/rand.h>
 #include <openssl/ssl.h>
 
-#include <boost/circular_buffer.hpp>
-
 #include "libssl.hh"
 
 /* From rfc5077 Section 4. Recommended Ticket Construction */

diff --git a/pdns/recursordist/Makefile.am b/pdns/recursordist/Makefile.am
index 4466319b7eb8a367140dcbdd74b2554ffa1d6d74..9a1e7a361582f22cccaea39820795c5727dc1846 100644 (file)
--- a/pdns/recursordist/Makefile.am
+++ b/pdns/recursordist/Makefile.am
@@ -100,6 +100,7 @@ pdns_recursor_SOURCES = \
        base64.cc base64.hh \
        cachecleaner.hh \
        capabilities.cc capabilities.hh \
+       circular_buffer.hh \
        comment.hh \
        dns.hh dns.cc \
        dns_random.hh dns_random.cc \
@@ -218,6 +219,7 @@ testrunner_SOURCES = \
        arguments.cc \
        base32.cc \
        base64.cc base64.hh \
+       circular_buffer.hh \
        dns.cc dns.hh \
        dns_random.cc dns_random.hh \
        dnslabeltext.cc \

diff --git a/pdns/recursordist/circular_buffer.hh b/pdns/recursordist/circular_buffer.hh
new file mode 120000 (symlink)
index 0000000..b0b7895
--- /dev/null
+++ b/pdns/recursordist/circular_buffer.hh
@@ -0,0 +1 @@
+../circular_buffer.hh
\ No newline at end of file

diff --git a/pdns/remote_logger.hh b/pdns/remote_logger.hh
index 5c6dfcfab4d9a4673a227919af7ca0068546a656..d5356c2d3e2b232f8f8c9286b9d0c042a67ba4be 100644 (file)
--- a/pdns/remote_logger.hh
+++ b/pdns/remote_logger.hh
@@ -30,7 +30,7 @@
 #include <thread>
 
 #include "iputils.hh"
-#include <boost/circular_buffer.hpp>
+#include "circular_buffer.hh"
 
 /* Writes can be submitted and they are atomically accepted. Either the whole write
    ends up in the buffer or nothing ends up in the buffer.

diff --git a/pdns/statbag.hh b/pdns/statbag.hh
index f36c211f636f886096f9a779a662c908c2f2cc6e..a9839693f26ce4af49d4a7bd1fac9e44430ba5f1 100644 (file)
--- a/pdns/statbag.hh
+++ b/pdns/statbag.hh
@@ -29,7 +29,7 @@
 #include "lock.hh"
 #include "namespaces.hh"
 #include "iputils.hh"
-#include <boost/circular_buffer.hpp>
+#include "circular_buffer.hh"
 
 
 

diff --git a/pdns/syncres.hh b/pdns/syncres.hh
index 06626f710cf3e563e2d8ace76c3c48ece54b053d..1d6ef2d2c71e48fbd3b725e58b141cb9a09110cf 100644 (file)
--- a/pdns/syncres.hh
+++ b/pdns/syncres.hh
@@ -35,8 +35,8 @@
 #include "misc.hh"
 #include "lwres.hh"
 #include <boost/optional.hpp>
-#include <boost/circular_buffer.hpp>
 #include <boost/utility.hpp>
+#include "circular_buffer.hh"
 #include "sstuff.hh"
 #include "recursor_cache.hh"
 #include "recpacketcache.hh"

diff --git a/pdns/ws-api.cc b/pdns/ws-api.cc
index ae62d7dd7f02b9381cd394b1b4c9b707864edad6..54dde00791283a1525a55aec8e4e94d5f73db71d 100644 (file)
--- a/pdns/ws-api.cc
+++ b/pdns/ws-api.cc
@@ -24,7 +24,6 @@
 #endif
 
 #include <boost/tokenizer.hpp>
-#include <boost/circular_buffer.hpp>
 #include "namespaces.hh"
 #include "ws-api.hh"
 #include "json.hh"