Fixed base64 issue with UTF-8 strings

Signed-off-by: Nicolas Williams <nico@cryptonector.com>

diff --git a/builtin.c b/builtin.c
index 8a809f51523ca49e613de61bbd813d11620f1971..6a1d7961c240792d1fe19810aac833dfb1d6f9d7 100644 (file)
--- a/builtin.c
+++ b/builtin.c
@@ -454,7 +454,7 @@ static jv f_format(jv input, jv fmt) {
     input = f_tostring(input);
     jv line = jv_string("");
     const char b64[64 + 1] = CHARS_ALPHANUM "+/";
-    const char* data = jv_string_value(input);
+    const unsigned char* data = (const unsigned char*)jv_string_value(input);
     int len = jv_string_length_bytes(jv_copy(input));
     for (int i=0; i<len; i+=3) {
       uint32_t code = 0;

diff --git a/tests/all.test b/tests/all.test
index 171c8087eaad957158f8632fd86666e4c42505b5..3b52ec904d650eb37d1a7e1ec8c11c09f4cbb200 100644 (file)
--- a/tests/all.test
+++ b/tests/all.test
@@ -71,6 +71,11 @@ null
 "'<>&'\\''\"'"
 "PD4mJyI="
 
+# regression test for #436
+@base64
+"foóbar\n"
+"Zm/Ds2Jhcgo="
+
 @uri
 "\u03bc"
 "%CE%BC"