Allow quotes in group names. Untested.

diff --git a/mod_authnz_external/CHANGES b/mod_authnz_external/CHANGES
index b48d0c297688bb5f958a35da0636b66d6f6b2ec5..e60525b36f028e3506a92210bde1b5cf9ceb803f 100644 (file)
--- a/mod_authnz_external/CHANGES
+++ b/mod_authnz_external/CHANGES
@@ -1,3 +1,9 @@
+v3.2.6   (Jan Wolter - )
+-----------------------------------------------
+ * Modified parsing of "Require groups" line so that you can have group
+   names that include spaces by enclosing them in quotes.  Haven't actually
+   tested this yet.
+
 v3.2.5   (Jan Wolter - Oct 29, 2009)
 -----------------------------------------------
  * Fixed a bug introduced in 3.2.0 in which data for checkpassword-type

diff --git a/mod_authnz_external/INSTALL b/mod_authnz_external/INSTALL
index 9201510e4cd2f0b585df040dc0adac7f00d122aa..68048036a6a5acf14f91f33fc090b6ce51438cc6 100644 (file)
--- a/mod_authnz_external/INSTALL
+++ b/mod_authnz_external/INSTALL
@@ -451,6 +451,11 @@ instructions to your server configuration.
 
         GroupExternalManyAtOnce off
 
+    If you have GroupExternalManyAtOnce turned off, then you can have
+    spaces in your group names by enclosing the names in quote marks.
+    If it is on, then all parsing of the group name list is up to your
+    authenticator.
+
     If, instead of listing group names, you want to allow access only
     to users whose group name (as determined by whatever group database
     your external group checker uses) matches the unix group name that

diff --git a/mod_authnz_external/mod_authnz_external.c b/mod_authnz_external/mod_authnz_external.c
index d90ff84ac12435f26175971960ccf962995cee8e..94e52a3844a3012f62262e62b3c9b6b06d35d5a3 100644 (file)
--- a/mod_authnz_external/mod_authnz_external.c
+++ b/mod_authnz_external/mod_authnz_external.c
@@ -724,7 +724,7 @@ static int authz_external_check_user_access(request_rec *r)
                {
                    /* Call authenticator once for each group name on line */
                    do {
-                       w= ap_getword_white(r->pool, &t);
+                       w= ap_getword_conf(r->pool, &t);
                        code= exec_external(extpath,
                                extmethod, r, ENV_GROUP, w);
                        if (code == 0) return OK;