]> granicus.if.org Git - clang/commitdiff
Use LLVM_DELETED_FUNCTION rather than '// do not implement' comments.
authorDavid Blaikie <dblaikie@gmail.com>
Mon, 18 Feb 2013 23:11:09 +0000 (23:11 +0000)
committerDavid Blaikie <dblaikie@gmail.com>
Mon, 18 Feb 2013 23:11:09 +0000 (23:11 +0000)
Also removes some redundant DNI comments on function declarations already
using the macro.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@175465 91177308-0d34-0410-b5e6-96231b3b80d8

include/clang/Driver/OptSpecifier.h
include/clang/Serialization/GlobalModuleIndex.h
include/clang/StaticAnalyzer/Core/BugReporter/PathDiagnostic.h
include/clang/StaticAnalyzer/Core/PathSensitive/SVals.h

index bb1cd1740bbbdc75fba2f3aab4c56e3c42e95152..e683ef325b8e0ae2aa3d7056841e6f6af973a49a 100644 (file)
@@ -10,6 +10,8 @@
 #ifndef CLANG_DRIVER_OPTSPECIFIER_H
 #define CLANG_DRIVER_OPTSPECIFIER_H
 
+#include "llvm/Support/Compiler.h"
+
 namespace clang {
 namespace driver {
   class Option;
@@ -19,7 +21,7 @@ namespace driver {
     unsigned ID;
 
   private:
-    explicit OptSpecifier(bool); // DO NOT IMPLEMENT
+    explicit OptSpecifier(bool) LLVM_DELETED_FUNCTION;
 
   public:
     OptSpecifier() : ID(0) {}
index 20d995e0adfa9a04a406f84f8f2709d2222a0557..ec8ad353e07d6d75b1efc7f00172b0f20ae08251 100644 (file)
@@ -94,8 +94,8 @@ class GlobalModuleIndex {
   explicit GlobalModuleIndex(FileManager &FileMgr, llvm::MemoryBuffer *Buffer,
                              llvm::BitstreamCursor Cursor);
 
-  GlobalModuleIndex(const GlobalModuleIndex &); // DO NOT IMPLEMENT
-  GlobalModuleIndex &operator=(const GlobalModuleIndex &); // DO NOT IMPLEMENT
+  GlobalModuleIndex(const GlobalModuleIndex &) LLVM_DELETED_FUNCTION;
+  GlobalModuleIndex &operator=(const GlobalModuleIndex &) LLVM_DELETED_FUNCTION;
 
 public:
   ~GlobalModuleIndex();
index 253ac8862e11e9abfd990cd62b6466ce54adba66..fa02c883879c3da23461a89697f822c606404516 100644 (file)
@@ -677,7 +677,7 @@ class PathDiagnostic : public llvm::FoldingSetNode {
   PathDiagnosticLocation UniqueingLoc;
   const Decl *UniqueingDecl;
 
-  PathDiagnostic(); // Do not implement.
+  PathDiagnostic() LLVM_DELETED_FUNCTION;
 public:
   PathDiagnostic(const Decl *DeclWithIssue, StringRef bugtype,
                  StringRef verboseDesc, StringRef shortDesc,
index 0fb5af6d07e1a1010a137bf77309f941a43b6ad0..d77a7969b4087ca375f3135530f8a6a064dea582 100644 (file)
@@ -168,10 +168,10 @@ public:
 
 class DefinedOrUnknownSVal : public SVal {
 private:
-  // Do not implement.  We want calling these methods to be a compiler
-  // error since they are tautologically false.
-  bool isUndef() const;
-  bool isValid() const;
+  // We want calling these methods to be a compiler error since they are
+  // tautologically false.
+  bool isUndef() const LLVM_DELETED_FUNCTION;
+  bool isValid() const LLVM_DELETED_FUNCTION;
   
 protected:
   explicit DefinedOrUnknownSVal(const void *d, bool isLoc, unsigned ValKind)
@@ -198,11 +198,11 @@ public:
 
 class DefinedSVal : public DefinedOrUnknownSVal {
 private:
-  // Do not implement.  We want calling these methods to be a compiler
-  // error since they are tautologically true/false.
-  bool isUnknown() const;
-  bool isUnknownOrUndef() const;
-  bool isValid() const;  
+  // We want calling these methods to be a compiler error since they are
+  // tautologically true/false.
+  bool isUnknown() const LLVM_DELETED_FUNCTION;
+  bool isUnknownOrUndef() const LLVM_DELETED_FUNCTION;
+  bool isValid() const LLVM_DELETED_FUNCTION;
 protected:
   explicit DefinedSVal(const void *d, bool isLoc, unsigned ValKind)
     : DefinedOrUnknownSVal(d, isLoc, ValKind) {}