Fixed bug #79282

diff --git a/ext/exif/exif.c b/ext/exif/exif.c
index dfa7cb2d6e93cd85920a628e56cde47cfc151e14..2bb34d972b87018a3c6574125d4f9e252b0a85a1 100644 (file)
--- a/ext/exif/exif.c
+++ b/ext/exif/exif.c
@@ -3642,6 +3642,11 @@ static void exif_process_TIFF_in_JPEG(image_info_type *ImageInfo, char *CharBuf,
        unsigned exif_value_2a, offset_of_ifd;
        exif_offset_info info;
 
+       if (length < 2) {
+               exif_error_docref(NULL EXIFERR_CC, ImageInfo, E_WARNING, "Missing TIFF alignment marker");
+               return;
+       }
+
        /* set the thumbnail stuff to nothing so we can test to see if they get set up */
        if (memcmp(CharBuf, "II", 2) == 0) {
                ImageInfo->motorola_intel = 0;
@@ -3795,7 +3800,7 @@ static int exif_scan_JPEG_header(image_info_type *ImageInfo)
                        return FALSE;
                }
 
-               sn = exif_file_sections_add(ImageInfo, marker, itemlen+1, NULL);
+               sn = exif_file_sections_add(ImageInfo, marker, itemlen, NULL);
                Data = ImageInfo->file.list[sn].data;
 
                /* Store first two pre-read bytes. */

diff --git a/ext/exif/tests/bug79282.phpt b/ext/exif/tests/bug79282.phpt
new file mode 100644 (file)
index 0000000..7b7e365
--- /dev/null
+++ b/ext/exif/tests/bug79282.phpt
@@ -0,0 +1,15 @@
+--TEST--
+Bug #79282: Use-of-uninitialized-value in exif
+--FILE--
+<?php
+
+var_dump(exif_read_data('data://image/jpeg;base64,/9jhAAlFeGlmAAAg'));
+
+?>
+--EXPECTF--
+Warning: exif_read_data(): Invalid TIFF alignment marker in %s on line %d
+
+Warning: exif_read_data(): File structure corrupted in %s on line %d
+
+Warning: exif_read_data(): Invalid JPEG file in %s on line %d
+bool(false)