Switch Wmodule-build to a remark

On reflection, this is better despite the missing command-line handling
bits for remarks.  Making this a remark makes it much clearer that
this is purely informational and avoids the negative connotations of a
'warning'.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@208367 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/include/clang/Basic/DiagnosticFrontendKinds.td b/include/clang/Basic/DiagnosticFrontendKinds.td
index 8fd77aef88bf52294924b7601b1e9f2457209241..91faa0a69c2bb8377f0fc85dd33885e9ce99ed2e 100644 (file)
--- a/include/clang/Basic/DiagnosticFrontendKinds.td
+++ b/include/clang/Basic/DiagnosticFrontendKinds.td
@@ -169,7 +169,7 @@ def warn_module_config_macro_undef : Warning<
   InGroup<ConfigMacros>;
 def note_module_def_undef_here : Note<
   "macro was %select{defined|#undef'd}0 here">;
-def warn_module_build : Warning<"building module '%0' as '%1'">,
+def remark_module_build : Remark<"building module '%0' as '%1'">,
   InGroup<DiagGroup<"module-build">>, DefaultIgnore;
 
 def err_missing_vfs_overlay_file : Error<

diff --git a/lib/Frontend/CompilerInstance.cpp b/lib/Frontend/CompilerInstance.cpp
index da0ca468cd3d532d87f35dbed0f737557dc339f4..9e07e747e879f56146662fa251a31fe99f80f1a3 100644 (file)
--- a/lib/Frontend/CompilerInstance.cpp
+++ b/lib/Frontend/CompilerInstance.cpp
@@ -1212,7 +1212,7 @@ CompilerInstance::loadModule(SourceLocation ImportLoc,
         return ModuleLoadResult();
       }
 
-      getDiagnostics().Report(ImportLoc, diag::warn_module_build)
+      getDiagnostics().Report(ImportLoc, diag::remark_module_build)
           << ModuleName << ModuleFileName;
 
       // Check whether we have already attempted to build this module (but

diff --git a/test/Modules/Wmodule-build.m b/test/Modules/Rmodule-build.m
similarity index 84%
rename from test/Modules/Wmodule-build.m
rename to test/Modules/Rmodule-build.m
index 74e020965c46bdbb87607f47da09c15f81b62827..4ac36efe898033acc3629e76e7eb1ae83f773c6b 100644 (file)
--- a/test/Modules/Wmodule-build.m
+++ b/test/Modules/Rmodule-build.m
@@ -9,8 +9,8 @@
 // RUN: %clang_cc1 -fmodules -fmodules-cache-path=%t -fsyntax-only %s -verify \
 // RUN:            -I %t -Wmodule-build
 
-@import A; // expected-warning{{building module 'A' as}}
-@import B; // expected-warning{{building module 'B' as}}
+@import A; // expected-remark{{building module 'A' as}}
+@import B; // expected-remark{{building module 'B' as}}
 @import A; // no diagnostic
 @import B; // no diagnostic