]> granicus.if.org Git - clang/commitdiff
clang-format: Fix incorrect pointer detection.
authorDaniel Jasper <djasper@google.com>
Wed, 23 Dec 2015 18:01:29 +0000 (18:01 +0000)
committerDaniel Jasper <djasper@google.com>
Wed, 23 Dec 2015 18:01:29 +0000 (18:01 +0000)
Before:
  return * this += 1;

After:
  return *this += 1;

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@256342 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTest.cpp

index e06389c31725390616c243815580c59ee69ace21..52dd831b6779ce1ac6d4d0f4a01a2d0579ba92ed 100644 (file)
@@ -831,7 +831,7 @@ private:
 
   void modifyContext(const FormatToken &Current) {
     if (Current.getPrecedence() == prec::Assignment &&
-        !Line.First->isOneOf(tok::kw_template, tok::kw_using) &&
+        !Line.First->isOneOf(tok::kw_template, tok::kw_using, tok::kw_return) &&
         (!Current.Previous || Current.Previous->isNot(tok::kw_operator))) {
       Contexts.back().IsExpression = true;
       if (!Line.startsWith(TT_UnaryOperator)) {
index 6245f8c043480f4da964f3a0597e31bde92b2d64..ac7bd5abf714c4521f3ef5fe218bd4dafdeeadf7 100644 (file)
@@ -5613,6 +5613,7 @@ TEST_F(FormatTest, UnderstandsUsesOfStarAndAmp) {
   Left.PointerAlignment = FormatStyle::PAS_Left;
   verifyFormat("x = *a(x) = *a(y);", Left);
   verifyFormat("for (;; * = b) {\n}", Left);
+  verifyFormat("return *this += 1;", Left);
 
   verifyIndependentOfContext("a = *(x + y);");
   verifyIndependentOfContext("a = &(x + y);");