top: miscellaneous accumulated tweaks of code/comments

This commit contains the following changes, which were
prompted by a coverity analysis which Craig initiated:

. comment typo predicting 'String not null terminated'
. eliminate 'Logically dead code' from insp_make_row()

And this tweak unrelated to coverity is also included:

. use more modern (recommended) approach for time call

Signed-off-by: Jim Warner <james.warner@comcast.net>

diff --git a/top/top.c b/top/top.c
index a30228bd7295050835e4f624e523c8e322ae72de..7eac2b23ee7a4e6b6d2f3f8ee7e94be382ff763b 100644 (file)
--- a/top/top.c
+++ b/top/top.c
@@ -818,7 +818,7 @@ static int ioch (int ech, char *buf, unsigned cnt) {
    // it may have been the beginning of a lengthy escape sequence
    tcflush(STDIN_FILENO, TCIFLUSH);
 
-   // note: we do NOT produce a vaid 'string'
+   // note: we do NOT produce a valid 'string'
    return rc;
 } // end: ioch
 
@@ -2304,7 +2304,7 @@ static void sysinfo_refresh (int forced) {
 
    if (forced)
       mem_secs = cpu_secs = 0;
-   time(&cur_secs);
+   cur_secs = time(NULL);
 
    /*** hotplug_acclimated ***/
    if (3 <= cur_secs - mem_secs) {
@@ -2614,7 +2614,6 @@ static inline void insp_make_row (int col, int row) {
    int fr, to, ofs;
    int hicap = 0;
 
-   capNO;
    if (col < INSP_RLEN(row))
       memcpy(tline, Insp_p[row] + col, sizeof(tline));
    else tline[0] = '\n';