]> granicus.if.org Git - python/commitdiff
Move the assert which checks for a NULL pointer first.
authorNeal Norwitz <nnorwitz@gmail.com>
Sat, 12 Aug 2006 01:51:12 +0000 (01:51 +0000)
committerNeal Norwitz <nnorwitz@gmail.com>
Sat, 12 Aug 2006 01:51:12 +0000 (01:51 +0000)
Klocwork #274.

Modules/collectionsmodule.c

index 01a7ad057b4d0ecb876601bb4c72367eb2f6457e..aef5d710c10778bf28ba3d9f928d3496540ae051 100644 (file)
@@ -224,9 +224,9 @@ deque_popleft(dequeobject *deque, PyObject *unused)
                        deque->leftindex = CENTER + 1;
                        deque->rightindex = CENTER;
                } else {
+                       assert(deque->leftblock != NULL);
                        assert(deque->leftblock != deque->rightblock);
                        prevblock = deque->leftblock->rightlink;
-                       assert(deque->leftblock != NULL);
                        PyMem_Free(deque->leftblock);
                        assert(prevblock != NULL);
                        prevblock->leftlink = NULL;