]> granicus.if.org Git - php/commitdiff
show_source() safe-mode fix
authorRasmus Lerdorf <rasmus@php.net>
Sat, 11 May 2002 18:35:59 +0000 (18:35 +0000)
committerRasmus Lerdorf <rasmus@php.net>
Sat, 11 May 2002 18:35:59 +0000 (18:35 +0000)
@ show_source() was evading safe-mode - fixed (Rasmus)

ext/standard/basic_functions.c
ext/standard/url_scanner_ex.c

index cbb9922da6bb0ec27db99d1ff00ec04aec643418..27452efa196bc224bed35004939e759fdfe567c0 100644 (file)
@@ -1866,6 +1866,14 @@ PHP_FUNCTION(highlight_file)
        }
        convert_to_string(filename);
 
+       if (PG(safe_mode) && (!php_checkuid(Z_STRVAL_P(filename), NULL, CHECKUID_ALLOW_ONLY_FILE))) {
+               RETURN_FALSE;
+       }
+
+       if (php_check_open_basedir(Z_STRVAL_P(filename) TSRMLS_CC)) {
+               RETURN_FALSE;
+       }
+
        if (i) {
                php_start_ob_buffer (NULL, 0, 1 TSRMLS_CC);
        }
index 41e8fb7436b85c763bbab9cd40f33a02352cb0c4..9ec1458788d8e192cd0269c6d3d2bbe050957e38 100644 (file)
@@ -1,5 +1,5 @@
-/* Generated by re2c 0.5 on Sun May  5 18:40:01 2002 */
-#line 1 "/home/thies/devel/php4/ext/standard/url_scanner_ex.re"
+/* Generated by re2c 0.5 on Wed May  8 08:08:09 2002 */
+#line 1 "/home/rasmus/php4/ext/standard/url_scanner_ex.re"
 /*
   +----------------------------------------------------------------------+
   | PHP Version 4                                                        |