]> granicus.if.org Git - llvm/commitdiff
PR28400: Partly undo r274440 to bring test-suite back to life with the new PM
authorSean Silva <chisophugis@gmail.com>
Sun, 3 Jul 2016 03:35:06 +0000 (03:35 +0000)
committerSean Silva <chisophugis@gmail.com>
Sun, 3 Jul 2016 03:35:06 +0000 (03:35 +0000)
PR28400 seems to be not an isolated issue, but a general problem related
to caching analyses. We will need to discuss on llvm-dev.

A test case is in the PR.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@274457 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Transforms/Scalar/JumpThreading.cpp

index bb3352c91a405dc9ca36bea64acd308ce11a2062..8e6020bb22e114614e805a492246dc29456c62d3 100644 (file)
@@ -151,7 +151,8 @@ PreservedAnalyses JumpThreadingPass::run(Function &F,
   if (!Changed)
     return PreservedAnalyses::all();
   PreservedAnalyses PA;
-  PA.preserve<LazyValueAnalysis>();
+  // FIXME: Not preserving LVI! We need it to be invalidated so that we
+  // don't run into issues like PR28400. Is there a better solution?
   PA.preserve<GlobalsAA>();
   return PA;
 }