]> granicus.if.org Git - esp-idf/commitdiff
ws_client: fix double delete issue in ws client initialization
authorDavid Cermak <cermak@espressif.com>
Thu, 20 Jun 2019 15:48:11 +0000 (17:48 +0200)
committerDavid Cermak <cermak@espressif.com>
Mon, 15 Jul 2019 11:15:07 +0000 (13:15 +0200)
components/esp_websocket_client/esp_websocket_client.c

index e545559dc89cfbb13e86d6b03891f76a80cddf27..a066c288c916d09f9902e6b79701cbfa77f99473 100644 (file)
@@ -153,42 +153,24 @@ static esp_err_t esp_websocket_client_set_config(esp_websocket_client_handle_t c
     if (config->username) {
         free(cfg->username);
         cfg->username = strdup(config->username);
-        ESP_WS_CLIENT_MEM_CHECK(TAG, cfg->username, {
-            free(cfg->host);
-            return ESP_ERR_NO_MEM;
-        });
+        ESP_WS_CLIENT_MEM_CHECK(TAG, cfg->username, return ESP_ERR_NO_MEM);
     }
 
     if (config->password) {
         free(cfg->password);
         cfg->password = strdup(config->password);
-        ESP_WS_CLIENT_MEM_CHECK(TAG, cfg->password, {
-            free(cfg->host);
-            free(cfg->username);
-            return ESP_ERR_NO_MEM;
-        });
+        ESP_WS_CLIENT_MEM_CHECK(TAG, cfg->password, return ESP_ERR_NO_MEM);
     }
 
     if (config->uri) {
         free(cfg->uri);
         cfg->uri = strdup(config->uri);
-        ESP_WS_CLIENT_MEM_CHECK(TAG, cfg->uri, {
-            free(cfg->host);
-            free(cfg->username);
-            free(cfg->password);
-            return ESP_ERR_NO_MEM;
-        });
+        ESP_WS_CLIENT_MEM_CHECK(TAG, cfg->uri, return ESP_ERR_NO_MEM);
     }
     if (config->path) {
         free(cfg->path);
         cfg->path = strdup(config->path);
-        ESP_WS_CLIENT_MEM_CHECK(TAG, cfg->path, {
-            free(cfg->uri);
-            free(cfg->host);
-            free(cfg->username);
-            free(cfg->password);
-            return ESP_ERR_NO_MEM;
-        });
+        ESP_WS_CLIENT_MEM_CHECK(TAG, cfg->path, return ESP_ERR_NO_MEM);
     }
 
     cfg->network_timeout_ms = WEBSOCKET_NETWORK_TIMEOUT_MS;