Return 500 when no api action is successful

fixes #5095

diff --git a/lib/remote/actionshandler.cpp b/lib/remote/actionshandler.cpp
index a8b31fc1099bf822ba96cc73106ce6e135610def..9358f7b32b682711036fb13679eba54d5ad522fa 100644 (file)
--- a/lib/remote/actionshandler.cpp
+++ b/lib/remote/actionshandler.cpp
@@ -91,11 +91,19 @@ bool ActionsHandler::HandleRequest(const ApiUser::Ptr& user, HttpRequest& reques
                }
        }
 
+       response.SetStatus(500, "No action executed successfully");
+
+       for (const Dictionary::Ptr& res : results) {
+               if (res->Contains("result") && res->Get("result") == 200) {
+                       response.SetStatus(200, "OK");
+                       break;
+               }
+       }
+
        Dictionary::Ptr result = new Dictionary({
                { "results", new Array(std::move(results)) }
        });
 
-       response.SetStatus(200, "OK");
        HttpUtility::SendJsonBody(response, params, result);
 
        return true;