PyObject_IsTrue() can return an error condition.

Adding code to handle it properly.

diff --git a/Modules/_randommodule.c b/Modules/_randommodule.c
index 00863b6691e3c0e03e045aadd1243e197db0e4fa..1a004a9fe140a37738c7a9f5bfe70742ede5fbbb 100644 (file)
--- a/Modules/_randommodule.c
+++ b/Modules/_randommodule.c
@@ -213,6 +213,7 @@ random_seed(RandomObject *self, PyObject *args)
        unsigned long *key = NULL;
        unsigned long keymax;           /* # of allocated slots in key */
        unsigned long keyused;          /* # of used slots in key */
+       int err;
 
        PyObject *arg = NULL;
 
@@ -261,11 +262,13 @@ random_seed(RandomObject *self, PyObject *args)
        thirtytwo = PyInt_FromLong(32L);
        if (thirtytwo == NULL)
                goto Done;
-       while (PyObject_IsTrue(n)) {
+       while ((err=PyObject_IsTrue(n))) {
                PyObject *newn;
                PyObject *pychunk;
                unsigned long chunk;
 
+               if (err == -1)
+                       goto Done;
                pychunk = PyNumber_And(n, masklower);
                if (pychunk == NULL)
                        goto Done;