]> granicus.if.org Git - php/commitdiff
Pass worker ID to clean scripts
authorChristoph M. Becker <cmbecker69@gmx.de>
Wed, 29 Apr 2020 09:12:03 +0000 (11:12 +0200)
committerChristoph M. Becker <cmbecker69@gmx.de>
Wed, 29 Apr 2020 11:30:28 +0000 (13:30 +0200)
On Windows, reusing/sharing of OPcache instances with different
configuration is not necessarily supported, so we have to make that it
does not happen for the clean scripts, by using `$orig_ini_settings`
instead of `$clean_params`.

run-tests.php

index e632f69a828f5b0a5254ab3aebf933cc1a16af8d..5a6ac531fc38ee407804e9f476214aa44cc5354c 100755 (executable)
@@ -2473,12 +2473,9 @@ COMMAND $cmd
             save_text($test_clean, trim($section_text['CLEAN']), $temp_clean);
 
             if (!$no_clean) {
-                $clean_params = array();
-                settings2array($ini_overwrites, $clean_params);
-                $clean_params = settings2params($clean_params);
                 $extra = substr(PHP_OS, 0, 3) !== "WIN" ?
                     "unset REQUEST_METHOD; unset QUERY_STRING; unset PATH_TRANSLATED; unset SCRIPT_FILENAME; unset REQUEST_METHOD;" : "";
-                system_with_timeout("$extra $php $pass_options $extra_options -q $clean_params $no_file_cache \"$test_clean\"", $env);
+                system_with_timeout("$extra $php $pass_options $extra_options -q $orig_ini_settings $no_file_cache \"$test_clean\"", $env);
             }
 
             if (!$cfg['keep']['clean']) {