Use LOG instead of DEBUG2 for logging invalid cancel requests. (That is,

cancel requests with an incorrect key, or with a non-existent PID). Per
recent discussion on -hackers.

diff --git a/src/backend/postmaster/postmaster.c b/src/backend/postmaster/postmaster.c
index ff4ee39ddaf91f5be5cb60dda651ceea03398762..db72f94abf4b099e8f72a7e58fdac60ea134c380 100644 (file)
--- a/src/backend/postmaster/postmaster.c
+++ b/src/backend/postmaster/postmaster.c
@@ -37,7 +37,7 @@
  *
  *
  * IDENTIFICATION
- *       $PostgreSQL: pgsql/src/backend/postmaster/postmaster.c,v 1.543 2007/10/26 21:50:10 mha Exp $
+ *       $PostgreSQL: pgsql/src/backend/postmaster/postmaster.c,v 1.544 2007/11/05 00:00:34 neilc Exp $
  *
  * NOTES
  *
@@ -1709,17 +1709,17 @@ processCancelRequest(Port *port, void *pkt)
                        }
                        else
                                /* Right PID, wrong key: no way, Jose */
-                               ereport(DEBUG2,
-                                (errmsg_internal("bad key in cancel request for process %d",
-                                                                 backendPID)));
+                               ereport(LOG,
+                                               (errmsg("bad key in cancel request for process %d",
+                                                               backendPID)));
                        return;
                }
        }
 
        /* No matching backend */
-       ereport(DEBUG2,
-                       (errmsg_internal("bad pid in cancel request for process %d",
-                                                        backendPID)));
+       ereport(LOG,
+                       (errmsg("bad pid in cancel request for process %d",
+                                       backendPID)));
 }
 
 /*