Don't crash initdb when we fail to get the current username.

Give an error message and exit instead, like we do elsewhere...

Per report from Wez Furlong and Robert Treat.

diff --git a/src/bin/initdb/initdb.c b/src/bin/initdb/initdb.c
index c3b7ee1b3da9664d1032047cf897019b7651e609..e3b00cec7df3549569871fae42f27d5224e15a51 100644 (file)
--- a/src/bin/initdb/initdb.c
+++ b/src/bin/initdb/initdb.c
@@ -42,7 +42,7 @@
  * Portions Copyright (c) 1994, Regents of the University of California
  * Portions taken from FreeBSD.
  *
- * $PostgreSQL: pgsql/src/bin/initdb/initdb.c,v 1.152.2.4 2008/10/30 08:51:13 petere Exp $
+ * $PostgreSQL: pgsql/src/bin/initdb/initdb.c,v 1.152.2.5 2009/03/31 18:58:38 mha Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -673,6 +673,13 @@ get_id(void)
                                progname);
                exit(1);
        }
+       if (!pw)
+       {
+               fprintf(stderr,
+                               _("%s: could not obtain information about current user: %s\n"),
+                               progname, strerror(errno));
+               exit(1);
+       }
 #else                                                  /* the windows code */
 
        struct passwd_win32
@@ -684,7 +691,12 @@ get_id(void)
        DWORD           pwname_size = sizeof(pass_win32.pw_name) - 1;
 
        pw->pw_uid = 1;
-       GetUserName(pw->pw_name, &pwname_size);
+       if (!GetUserName(pw->pw_name, &pwname_size))
+       {
+               fprintf(stderr, _("%s: could not get current user name: %s\n"),
+                               progname, strerror(errno));
+               exit(1);
+       }
 #endif
 
        return xstrdup(pw->pw_name);