patch 8.1.1077: reg_executing() is reset by calling input()

Problem:    reg_executing() is reset by calling input().
Solution:   Implement a more generic way to save and restore reg_executing.
            (Ozaki Kiichi, closes #4192)

diff --git a/src/evalfunc.c b/src/evalfunc.c
index 72ffd52d994558d6c1a67f3e445dcfc2fb7bb1be..30f98eb6638296c598c304e9eae9acf9f69d284d 100644 (file)
--- a/src/evalfunc.c
+++ b/src/evalfunc.c
@@ -4848,7 +4848,6 @@ f_getchar(typval_T *argvars, typval_T *rettv)
 {
     varnumber_T                n;
     int                        error = FALSE;
-    int                        save_reg_executing = reg_executing;
 
 #ifdef MESSAGE_QUEUE
     // vpeekc() used to check for messages, but that caused problems, invoking
@@ -4883,7 +4882,6 @@ f_getchar(typval_T *argvars, typval_T *rettv)
     }
     --no_mapping;
     --allow_keys;
-    reg_executing = save_reg_executing;
 
     set_vim_var_nr(VV_MOUSE_WIN, 0);
     set_vim_var_nr(VV_MOUSE_WINID, 0);

diff --git a/src/ex_docmd.c b/src/ex_docmd.c
index f30d9336af244197a03316912af95e93b6bedaf8..b253e9b734540633870f33110b0cf9907d472416 100644 (file)
--- a/src/ex_docmd.c
+++ b/src/ex_docmd.c
@@ -1699,6 +1699,7 @@ do_one_cmd(
     exarg_T            ea;                     /* Ex command arguments */
     int                        save_msg_scroll = msg_scroll;
     cmdmod_T           save_cmdmod;
+    int                        save_reg_executing = reg_executing;
     int                        ni;                     /* set when Not Implemented */
     char_u             *cmd;
 
@@ -2579,6 +2580,7 @@ doend:
 
     free_cmdmod();
     cmdmod = save_cmdmod;
+    reg_executing = save_reg_executing;
 
     if (ea.save_msg_silent != -1)
     {

diff --git a/src/testdir/test_functions.vim b/src/testdir/test_functions.vim
index d53499950e8ef42e2824aca8142f90a950d8dab9..63f477db9a23d0eb2eac846630449ec5c6961c69 100644 (file)
--- a/src/testdir/test_functions.vim
+++ b/src/testdir/test_functions.vim
@@ -1150,20 +1150,38 @@ func Test_reg_executing_and_recording()
   " getchar() command saves and restores reg_executing
   map W :call TestFunc()<CR>
   let @q = "W"
+  let g:typed = ''
+  let g:regs = []
   func TestFunc() abort
-    let g:reg1 = reg_executing()
+    let g:regs += [reg_executing()]
     let g:typed = getchar(0)
-    let g:reg2 = reg_executing()
+    let g:regs += [reg_executing()]
   endfunc
   call feedkeys("@qy", 'xt')
   call assert_equal(char2nr("y"), g:typed)
-  call assert_equal('q', g:reg1)
-  call assert_equal('q', g:reg2)
+  call assert_equal(['q', 'q'], g:regs)
   delfunc TestFunc
   unmap W
   unlet g:typed
-  unlet g:reg1
-  unlet g:reg2
+  unlet g:regs
+
+  " input() command saves and restores reg_executing
+  map W :call TestFunc()<CR>
+  let @q = "W"
+  let g:typed = ''
+  let g:regs = []
+  func TestFunc() abort
+    let g:regs += [reg_executing()]
+    let g:typed = input('?')
+    let g:regs += [reg_executing()]
+  endfunc
+  call feedkeys("@qy\<CR>", 'xt')
+  call assert_equal("y", g:typed)
+  call assert_equal(['q', 'q'], g:regs)
+  delfunc TestFunc
+  unmap W
+  unlet g:typed
+  unlet g:regs
 
   bwipe!
   delfunc s:save_reg_stat

diff --git a/src/version.c b/src/version.c
index 5505e6e897d9ca043989fa5b463a225b95a6a32b..e84b5db8d590b8f7a7b86f8bbf27102b7107fa08 100644 (file)
--- a/src/version.c
+++ b/src/version.c
@@ -775,6 +775,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    1077,
 /**/
     1076,
 /**/