evaluated first. This can also improve codegen just a bit as we might
have another register to play with for the evaluation of the rhs.
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@72226
91177308-0d34-0410-b5e6-
96231b3b80d8
}
Value *ScalarExprEmitter::VisitBinAssign(const BinaryOperator *E) {
- LValue LHS = EmitLValue(E->getLHS());
+ // __block variables need to have the rhs evaluated first, plus
+ // this should improve codegen just a little.
Value *RHS = Visit(E->getRHS());
+ LValue LHS = EmitLValue(E->getLHS());
// Store the value into the LHS. Bit-fields are handled specially
// because the result is altered by the store, i.e., [C99 6.5.16p1]
--- /dev/null
+// RUN: clang-cc -fblocks -triple x86_64-apple-darwin10 -emit-llvm -o %t %s &&
+// RUN: grep '%call = call i32 (...)\* @rhs()' %t | count 1 &&
+// If this fails, see about sliding %4 and %5...
+// RUN: grep '%forwarding1 = getelementptr %0\* %i, i32 0, i32 1' %t | count 1 &&
+// RUN: grep '%4 = bitcast i8\*\* %forwarding1 to %0\*\*' %t | count 1 &&
+// RUN: grep '%5 = load %0\*\* %4' %t | count 1
+
+int rhs();
+
+void foo() {
+ __block int i;
+ i = rhs();
+}