Before pam_end(), the return value of the previous

pam API was already checked. No need to validate it again.

diff --git a/ChangeLog b/ChangeLog
index e61035071dd3c96afeabfa8c555fa23576ebb872..a31f976207996f33d943d162a48453f18176025c 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -3,6 +3,8 @@
        newusers cleanups
        * src/newusers.c: main() split in new functions: process_flags(),
        check_flags(), check_perms(), open_files(), and close_files().
+       * src/newusers.c: Before pam_end(), the return value of the previous
+       pam API was already checked. No need to validate it again.
 
 2007-12-29  Nicolas François  <nicolas.francois@centraliens.net>
 

diff --git a/src/newusers.c b/src/newusers.c
index 2a30aa892252de983d11d1506e1a524f6c3f2658..3e562bb374ab016465695e1dc401aecfdd310edc 100644 (file)
--- a/src/newusers.c
+++ b/src/newusers.c
@@ -695,8 +695,7 @@ int main (int argc, char **argv)
        nscd_flush_cache ("group");
 
 #ifdef USE_PAM
-       if (retval == PAM_SUCCESS)
-               pam_end (pamh, PAM_SUCCESS);
+       pam_end (pamh, PAM_SUCCESS);
 #endif                         /* USE_PAM */
 
        exit (0);