- Reverting: pcntl_signal() returning NULL when passing wrong parameters

# Wow, my first commit and I broke something, sorry about that :(

diff --git a/ext/pcntl/pcntl.c b/ext/pcntl/pcntl.c
index b9d64d95ef8a6f2d955f2ccf35fa8830812fe44e..414446a0497658c600a030e6c7274bb02577b44d 100755 (executable)
--- a/ext/pcntl/pcntl.c
+++ b/ext/pcntl/pcntl.c
@@ -757,7 +757,7 @@ PHP_FUNCTION(pcntl_signal)
        zend_bool restart_syscalls = 1;
 
        if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "lz|b", &signo, &handle, &restart_syscalls) == FAILURE) {
-               RETURN_FALSE;
+               return;
        }
 
        if (!PCNTL_G(spares)) {

diff --git a/ext/pcntl/tests/pcntl_signal.phpt b/ext/pcntl/tests/pcntl_signal.phpt
index 324cc0b418c02b29ef5ae91108d7f250d466d236..977f26fbcc2f5252002131f49c2210f986b9effc 100644 (file)
--- a/ext/pcntl/tests/pcntl_signal.phpt
+++ b/ext/pcntl/tests/pcntl_signal.phpt
@@ -25,7 +25,7 @@ echo "ok\n";
 signal dispatched
 
 Warning: pcntl_signal() expects at least 2 parameters, 0 given in %s
-bool(false)
+NULL
 bool(true)
 
 Warning: pcntl_signal(): Invalid value for handle argument specified in %s