]> granicus.if.org Git - openjpeg/commitdiff
Add overflow check in opj_j2k_update_image_data (#817)
authorMatthieu Darbois <mayeut@users.noreply.github.com>
Mon, 5 Sep 2016 22:50:44 +0000 (00:50 +0200)
committerMathieu Malaterre <mathieu.malaterre@gmail.com>
Tue, 13 Sep 2016 09:00:08 +0000 (11:00 +0200)
src/lib/openjp2/j2k.c

index 9eaa155ed91d818dc8f9637148c7cfb836fae026..01d1a4fff1f2b05e715786faad6915cea2c5020b 100644 (file)
@@ -8217,8 +8217,14 @@ static OPJ_BOOL opj_j2k_update_image_data (opj_tcd_t * p_tcd, OPJ_BYTE * p_data,
 
                 /* Allocate output component buffer if necessary */
                 if (!l_img_comp_dest->data) {
+                        OPJ_SIZE_T l_width = l_img_comp_dest->w;
+                        OPJ_SIZE_T l_height = l_img_comp_dest->h;
 
-                        l_img_comp_dest->data = (OPJ_INT32*) opj_calloc((OPJ_SIZE_T)l_img_comp_dest->w * (OPJ_SIZE_T)l_img_comp_dest->h, sizeof(OPJ_INT32));
+                        if ((l_height == 0U) || (l_width > (SIZE_MAX / l_height))) {
+                                /* would overflow */
+                                return OPJ_FALSE;
+                        }
+                        l_img_comp_dest->data = (OPJ_INT32*) opj_calloc(l_width * l_height, sizeof(OPJ_INT32));
                         if (! l_img_comp_dest->data) {
                                 return OPJ_FALSE;
                         }