Fix

[ 1077106 ] Negative numbers to os.read() cause segfault

Sorry for sitting on this for so long!  Is there a chance it could
make 2.3.5?

diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c
index 7ecd8646c397ff374f14b0366b88f283aad53213..2d3eaa39cb5419e5e8a4efeab2dabaa2a7f43bd3 100644 (file)
--- a/Modules/posixmodule.c
+++ b/Modules/posixmodule.c
@@ -5349,6 +5349,10 @@ posix_read(PyObject *self, PyObject *args)
        PyObject *buffer;
        if (!PyArg_ParseTuple(args, "ii:read", &fd, &size))
                return NULL;
+       if (size < 0) {
+               errno = EINVAL;
+               return posix_error();
+       }
        buffer = PyString_FromStringAndSize((char *)NULL, size);
        if (buffer == NULL)
                return NULL;