]> granicus.if.org Git - python/commitdiff
Remove unneeded assignment in PyBytes_Concat() (GH-15274)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Tue, 10 Sep 2019 17:46:52 +0000 (10:46 -0700)
committerGitHub <noreply@github.com>
Tue, 10 Sep 2019 17:46:52 +0000 (10:46 -0700)
The `wb.len = -1` assignment is unneeded since its introduction in 161d695fb0455ce52530d4f43a9eac4c738f64bb as `PyObject_GetBuffer` always fills it in.
(cherry picked from commit afdeb189e97033b54cef44a7490d89d2013cb4e5)

Co-authored-by: Sergey Fedoseev <fedoseev.sergey@gmail.com>
Objects/bytesobject.c

index 06c87b0c62d3bb20e3e6a76150521bd49440fb48..9358e5effd567434bbe866edf538ba8b2843faaf 100644 (file)
@@ -2939,7 +2939,6 @@ PyBytes_Concat(PyObject **pv, PyObject *w)
         Py_ssize_t oldsize;
         Py_buffer wb;
 
-        wb.len = -1;
         if (PyObject_GetBuffer(w, &wb, PyBUF_SIMPLE) != 0) {
             PyErr_Format(PyExc_TypeError, "can't concat %.100s to %.100s",
                          Py_TYPE(w)->tp_name, Py_TYPE(*pv)->tp_name);