O_APPEND breaks 'c' for DBM files - this is handled

correctly by PHP3, so it's almost a forward'' port :)

diff --git a/NEWS b/NEWS
index e0d09490dcfc7a84a263e20e02816b32443e2a45..fdbe088485da6b347a7575512c6c83be19fd6aed 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -2,6 +2,8 @@ PHP 4.0                                                                    NEWS
 |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
 
 ?? ??? 2000, Version 4.0.1
+- Fixed a problem with dbmopen() not handing 'c' correctly with dbm/db/ndbm
+  databases. (JimJag)
 - Fixed an initialization problem in the MS-SQL problem that could cause
   a crash in mssql_query() (Zeev)
 - Upgraded PCRE to version 3.2 and fixed a bug when anchored pattern

diff --git a/ext/db/db.c b/ext/db/db.c
index c1c3fef11219b743b2e6dfaad4e7da3f74f6c301..50850124658d31bae167984b6dec900837578bb5 100644 (file)
--- a/ext/db/db.c
+++ b/ext/db/db.c
@@ -90,7 +90,7 @@
 #define DBM_TYPE DBM *
 #define DBM_MODE_TYPE int
 #define DBM_WRITE_MODE O_RDWR
-#define DBM_CREATE_MODE O_RDWR | O_APPEND | O_CREAT
+#define DBM_CREATE_MODE O_RDWR | O_CREAT
 #define DBM_NEW_MODE O_RDWR | O_CREAT | O_TRUNC
 #define DBM_DEFAULT_MODE O_RDONLY
 #define DBM_OPEN(filename, mode) dbm_open(filename, mode, 0666)