]> granicus.if.org Git - curl/commitdiff
ntlm: Return all errors from Curl_ntlm_core_mk_nt_hash()
authorSteve Holme <steve_holme@hotmail.com>
Sun, 26 Oct 2014 10:32:34 +0000 (10:32 +0000)
committerSteve Holme <steve_holme@hotmail.com>
Sun, 26 Oct 2014 09:14:46 +0000 (09:14 +0000)
For consistency with other areas of the NTLM code propagate all errors
from Curl_ntlm_core_mk_nt_hash() up the call stack rather than just
CURLE_OUT_OF_MEMORY.

lib/curl_ntlm_msgs.c

index 8f5ed58eeac711c425c74eb89ccfc4ca3d3f1f9e..1edefd7a292b1978878a3d84fa25eaa460fdd53c 100644 (file)
@@ -805,9 +805,9 @@ CURLcode Curl_ntlm_create_type3_message(struct SessionHandle *data,
 
     /* We shall only use the first 8 bytes of md5sum, but the des
        code in Curl_ntlm_core_lm_resp only encrypt the first 8 bytes */
-    if(CURLE_OUT_OF_MEMORY ==
-       Curl_ntlm_core_mk_nt_hash(data, passwdp, ntbuffer))
-      return CURLE_OUT_OF_MEMORY;
+    result = Curl_ntlm_core_mk_nt_hash(data, passwdp, ntbuffer);
+    if(result)
+      return result;
 
     Curl_ntlm_core_lm_resp(ntbuffer, md5sum, ntresp);
 
@@ -824,9 +824,10 @@ CURLcode Curl_ntlm_create_type3_message(struct SessionHandle *data,
     unsigned char lmbuffer[0x18];
 
 #if USE_NTRESPONSES
-    if(CURLE_OUT_OF_MEMORY ==
-       Curl_ntlm_core_mk_nt_hash(data, passwdp, ntbuffer))
-      return CURLE_OUT_OF_MEMORY;
+    result = Curl_ntlm_core_mk_nt_hash(data, passwdp, ntbuffer);
+    if(result)
+      return result;
+
     Curl_ntlm_core_lm_resp(ntbuffer, &ntlm->nonce[0], ntresp);
 #endif