Check for NULL result from strdup

Per Coverity Scan

diff --git a/src/interfaces/libpq/fe-secure.c b/src/interfaces/libpq/fe-secure.c
index b1ad776a234280e2921bf2378627070cc6005166..30182958a1da3e01abe3202b83c0709a859c5bbc 100644 (file)
--- a/src/interfaces/libpq/fe-secure.c
+++ b/src/interfaces/libpq/fe-secure.c
@@ -1132,7 +1132,17 @@ initialize_SSL(PGconn *conn)
                {
                        /* Colon, but not in second character, treat as engine:key */
                        char       *engine_str = strdup(conn->sslkey);
-                       char       *engine_colon = strchr(engine_str, ':');
+                       char       *engine_colon;
+
+                       if (engine_str == NULL)
+                       {
+                               printfPQExpBuffer(&conn->errorMessage,
+                                                                 libpq_gettext("out of memory\n"));
+                               return -1;
+                       }
+
+                       /* cannot return NULL because we already checked before strdup */
+                       engine_colon = strchr(engine_str, ':');
 
                        *engine_colon = '\0';           /* engine_str now has engine name */
                        engine_colon++;         /* engine_colon now has key name */