Remove the remapping of snprintf to _snprintf when compiling with MSC.

_snprintf and snprintf have one very important semantic difference.
_snprintf does NOT add terminating null character when the buffer limit
is reached while snprintf guarantees a terminating null character.  It
was a mistake to make this naming change hiding the fact that the
semantics don't match what the developer might expect.

diff --git a/include/ntconf.h b/include/ntconf.h
index 994615c2d7abd16febbba55566b6294440ad939f..9d79006f0cfc76bb572a174de13a1a5303a485fa 100644 (file)
--- a/include/ntconf.h
+++ b/include/ntconf.h
@@ -146,14 +146,6 @@ extern void NDECL(getlock);
 #define strncmpi(a, b, c) strnicmp(a, b, c)
 #endif
 
-#ifdef _MSC_VER
-/* Visual Studio defines this in their own headers, which we don't use */
-#ifndef snprintf
-#define snprintf _snprintf
-#pragma warning( \
-    disable : 4996) /* deprecation warning suggesting snprintf_s */
-#endif
-#endif
 
 #include <sys/types.h>
 #include <stdlib.h>