2011-03-13 Ivan Maidanski <ivmai@mail.ru>

	* src/atomic_ops/sysdeps/emul_cas.h: Fix a typo in a comment;
	expand all tabs to spaces.
	* src/atomic_ops/sysdeps/gcc/x86.h (AO_test_and_set_full):
	Recognize AO_XCHGB_RET_WORD new macro (to workaround a bug).
	* src/atomic_ops/sysdeps/gcc/x86_64.h (AO_test_and_set_full):
	Ditto.

diff --git a/ChangeLog b/ChangeLog
index 1b16707a8885b3ee4fcc6da246487b10b09bb0d0..70a183e02cab0ac4bc23e6dc007c86b8ce2a78e4 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2011-03-13  Ivan Maidanski  <ivmai@mail.ru>
+
+       * src/atomic_ops/sysdeps/emul_cas.h: Fix a typo in a comment;
+       expand all tabs to spaces.
+       * src/atomic_ops/sysdeps/gcc/x86.h (AO_test_and_set_full):
+       Recognize AO_XCHGB_RET_WORD new macro (to workaround a bug).
+       * src/atomic_ops/sysdeps/gcc/x86_64.h (AO_test_and_set_full):
+       Ditto.
+
 2011-02-19  Ivan Maidanski  <ivmai@mail.ru>
 
        * src/atomic_ops.c: Include sys/time.h (to get timespec) for NaCl.

diff --git a/src/atomic_ops/sysdeps/emul_cas.h b/src/atomic_ops/sysdeps/emul_cas.h
index 4187f9f39c48739041ed26def05129e0c7f4e83a..13fb2271aa7ff9fa9883aba88b59eb933c0cf74f 100644 (file)
--- a/src/atomic_ops/sysdeps/emul_cas.h
+++ b/src/atomic_ops/sysdeps/emul_cas.h
@@ -1,23 +1,23 @@
 /*
  * Copyright (c) 2003 by Hewlett-Packard Company.  All rights reserved.
- * 
+ *
  * Permission is hereby granted, free of charge, to any person obtaining a copy
  * of this software and associated documentation files (the "Software"), to deal
  * in the Software without restriction, including without limitation the rights
  * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
  * copies of the Software, and to permit persons to whom the Software is
  * furnished to do so, subject to the following conditions:
- * 
+ *
  * The above copyright notice and this permission notice shall be included in
  * all copies or substantial portions of the Software.
- * 
+ *
  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
  * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
  * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
- * SOFTWARE. 
+ * SOFTWARE.
  */
 
 /*
@@ -27,7 +27,7 @@
  * Including this file will generate an error if AO_compare_and_swap_full()
  * cannot be made available.
  * This will be included from platform-specific atomic_ops files
- * id appropriate, and if AO_FORCE_CAS is defined.  It should not be
+ * if appropriate, and if AO_FORCE_CAS is defined.  It should not be
  * included directly, especially since it affects the implementation
  * of other atomic update primitives.
  * The implementation assumes that only AO_store_XXX and AO_test_and_set_XXX
@@ -44,23 +44,23 @@
 #endif
 
 int AO_compare_and_swap_emulation(volatile AO_t *addr, AO_t old,
-                                 AO_t new_val);
+                                  AO_t new_val);
 
 int AO_compare_double_and_swap_double_emulation(volatile AO_double_t *addr,
-                                               AO_t old_val1, AO_t old_val2,
-                                               AO_t new_val1, AO_t new_val2);
+                                                AO_t old_val1, AO_t old_val2,
+                                                AO_t new_val1, AO_t new_val2);
 
 void AO_store_full_emulation(volatile AO_t *addr, AO_t val);
 
 #define AO_compare_and_swap_full(addr, old, newval) \
-       AO_compare_and_swap_emulation(addr, old, newval)
+       AO_compare_and_swap_emulation(addr, old, newval)
 #define AO_HAVE_compare_and_swap_full
 
 #ifndef AO_HAVE_compare_double_and_swap_double
 # define AO_compare_double_and_swap_double_full(addr, old1, old2, \
-                                               newval1, newval2) \
-        AO_compare_double_and_swap_double_emulation(addr, old1, old2, \
-                                                    newval1, newval2)
+                                                newval1, newval2) \
+        AO_compare_double_and_swap_double_emulation(addr, old1, old2, \
+                                                    newval1, newval2)
 # define AO_HAVE_compare_double_and_swap_double_full
 #endif
 

diff --git a/src/atomic_ops/sysdeps/gcc/x86.h b/src/atomic_ops/sysdeps/gcc/x86.h
index 8f73ac6a8b05b1a5cc1e7ea79716c67f83ab4159..d6b95aff0b17697829ac4e0904ecfd25b4169e66 100644 (file)
--- a/src/atomic_ops/sysdeps/gcc/x86.h
+++ b/src/atomic_ops/sysdeps/gcc/x86.h
@@ -109,7 +109,12 @@ AO_or_full (volatile AO_t *p, AO_t incr)
 AO_INLINE AO_TS_VAL_t
 AO_test_and_set_full(volatile AO_TS_t *addr)
 {
-  unsigned char oldval;
+# ifdef AO_XCHGB_RET_WORD
+    /* Workaround for a bug in LLVM v2.7 GAS.   */
+    unsigned oldval;
+# else
+    unsigned char oldval;
+# endif
   /* Note: the "xchg" instruction does not need a "lock" prefix */
   __asm__ __volatile__("xchgb %0, %1"
                 : "=q"(oldval), "=m"(*addr)

diff --git a/src/atomic_ops/sysdeps/gcc/x86_64.h b/src/atomic_ops/sysdeps/gcc/x86_64.h
index 2274a2d821079502b02fa47977f0ec393ef0f2e3..3d3eb7402253329b92930498a504e7229a678843 100644 (file)
--- a/src/atomic_ops/sysdeps/gcc/x86_64.h
+++ b/src/atomic_ops/sysdeps/gcc/x86_64.h
@@ -107,7 +107,12 @@ AO_or_full (volatile AO_t *p, AO_t incr)
 AO_INLINE AO_TS_VAL_t
 AO_test_and_set_full(volatile AO_TS_t *addr)
 {
-  unsigned char oldval;
+# ifdef AO_XCHGB_RET_WORD
+    /* Workaround for a bug in LLVM v2.7 GAS.   */
+    unsigned oldval;
+# else
+    unsigned char oldval;
+# endif
   /* Note: the "xchg" instruction does not need a "lock" prefix */
   __asm__ __volatile__("xchgb %0, %1"
                 : "=q"(oldval), "=m"(*addr)