]> granicus.if.org Git - apache/commitdiff
update a comment
authorCliff Woolley <jwoolley@apache.org>
Sat, 23 Nov 2002 21:18:16 +0000 (21:18 +0000)
committerCliff Woolley <jwoolley@apache.org>
Sat, 23 Nov 2002 21:18:16 +0000 (21:18 +0000)
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@97616 13f79535-47bb-0310-9956-ffa450edef68

modules/cache/mod_file_cache.c

index 646d77bf0b41c542e69a9134491fc0a298098c52..37209e274415b13ce9a339619841ab54fc19630b 100644 (file)
@@ -249,14 +249,12 @@ static void cache_the_file(cmd_parms *cmd, const char *filename, int mmap)
             return;
         }
         apr_file_close(fd);
-        /* We want to cache an apr_mmap_t that's marked as "non-owner"
-         * to pass to each request so that mmap_setaside()'s call to
-         * apr_mmap_dup() will never try to move the apr_mmap_t to a
-         * different pool.  This apr_mmap_t is already going to live
-         * longer than any request, but mmap_setaside() has no way to
-         * know that because it's allocated out of cmd->pool,
-         * which is disjoint from r->pool.
-         */
+        /* We want to cache a duplicate apr_mmap_t to pass to each
+         * request so that nothing in the request will ever think that
+         * it's allowed to delete the mmap, since the "refcount" will
+         * never reach zero. */
+        /* XXX: the transfer_ownership flag on this call
+         * will go away soon.. it's ignored right now. */
         apr_mmap_dup(&new_file->mm, mm, cmd->pool, 0);
         new_file->is_mmapped = TRUE;
     }