We have two exits from the function: either we jump to the out_stale
label or not. But in both exits we repeat our cleanup, and the only
difference is our return value. Let's just use a variable for the return
value to avoid repeating ourselves.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
FILE *fp;
char line[1000];
int old_cnt = 0;
+ int stale = 1;
fp = fopen_or_warn(infofile, "r");
if (!fp)
error("unrecognized: %s", line);
}
}
- fclose(fp);
- return 0;
+ stale = 0;
+
out_stale:
fclose(fp);
- return 1;
+ return stale;
}
static int compare_info(const void *a_, const void *b_)