bpo-29532: Altering a kwarg dictionary passed to functools.partial() (#190)

no longer affects a partial object after creation.

diff --git a/Lib/test/test_functools.py b/Lib/test/test_functools.py
index 63fe83e5dbd6028ecb4d68bbf74a4f43deac14e9..612ca17a60bc8cd90cbea0f32f059151a3c5e600 100644 (file)
--- a/Lib/test/test_functools.py
+++ b/Lib/test/test_functools.py
@@ -90,6 +90,15 @@ class TestPartial:
         p(b=7)
         self.assertEqual(d, {'a':3})
 
+    def test_kwargs_copy(self):
+        # Issue #29532: Altering a kwarg dictionary passed to a constructor
+        # should not affect a partial object after creation
+        d = {'a': 3}
+        p = self.partial(capture, **d)
+        self.assertEqual(p(), ((), {'a': 3}))
+        d['a'] = 5
+        self.assertEqual(p(), ((), {'a': 3}))
+
     def test_arg_combinations(self):
         # exercise special code paths for zero args in either partial
         # object or the caller

diff --git a/Misc/NEWS b/Misc/NEWS
index 0c2a5730e31388fbcf725811f28816724da097f7..fa7e3f5a5e7f0690040785485c810420f24809d0 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -232,6 +232,9 @@ Extension Modules
 Library
 -------
 
+- bpo-29532: Altering a kwarg dictionary passed to functools.partial()
+  no longer affects a partial object after creation.
+
 - bpo-22807: Add uuid.SafeUUID and uuid.UUID.is_safe to relay information from
   the platform about whether generated UUIDs are generated with a
   multiprocessing safe method.

diff --git a/Modules/_functoolsmodule.c b/Modules/_functoolsmodule.c
index 4170883368f953363bcf07606f3877264792b73c..c8565054c903de93d64ae7fc7e8ef652e47693c3 100644 (file)
--- a/Modules/_functoolsmodule.c
+++ b/Modules/_functoolsmodule.c
@@ -88,10 +88,13 @@ partial_new(PyTypeObject *type, PyObject *args, PyObject *kw)
         if (kw == NULL) {
             pto->kw = PyDict_New();
         }
-        else {
+        else if (Py_REFCNT(kw) == 1) {
             Py_INCREF(kw);
             pto->kw = kw;
         }
+        else {
+            pto->kw = PyDict_Copy(kw);
+        }
     }
     else {
         pto->kw = PyDict_Copy(pkw);