MFB: Optimize wddx boolean encoding

diff --git a/ext/wddx/php_wddx_api.h b/ext/wddx/php_wddx_api.h
index f137b262a95794b0899cf017c426559a32010885..3c194476bd6517d376f24ee5bf63331ddef8e9f6 100644 (file)
--- a/ext/wddx/php_wddx_api.h
+++ b/ext/wddx/php_wddx_api.h
@@ -27,7 +27,8 @@
 #define WDDX_ARRAY_E                   "</array>"
 #define WDDX_BINARY_S                  "<binary>"
 #define WDDX_BINARY_E                  "</binary>"
-#define WDDX_BOOLEAN                   "<boolean value='%s'/>"
+#define WDDX_BOOLEAN_TRUE              "<boolean value='true'/>"
+#define WDDX_BOOLEAN_FALSE             "<boolean value='false'/>"
 #define WDDX_CHAR                              "<char code='%02X'/>"
 #define WDDX_COMMENT_S                 "<comment>"
 #define WDDX_COMMENT_E                 "</comment>"

diff --git a/ext/wddx/wddx.c b/ext/wddx/wddx.c
index aa83b5027a8316997ab4af9698d29f2fde9044de..c55fb4496782d69c1f0bb66aba40d7f4d714be95 100644 (file)
--- a/ext/wddx/wddx.c
+++ b/ext/wddx/wddx.c
@@ -408,10 +408,7 @@ static void php_wddx_serialize_number(wddx_packet *packet, zval *var)
  */
 static void php_wddx_serialize_boolean(wddx_packet *packet, zval *var)
 {
-       char tmp_buf[WDDX_BUF_LEN];
-
-       snprintf(tmp_buf, sizeof(tmp_buf), WDDX_BOOLEAN, Z_LVAL_P(var) ? "true" : "false");
-       php_wddx_add_chunk(packet, tmp_buf);
+       php_wddx_add_chunk(packet, Z_LVAL_P(var) ? WDDX_BOOLEAN_TRUE : WDDX_BOOLEAN_FALSE);
 }
 /* }}} */