* lib/gshadow.c: Avoid assignments in comparison.

diff --git a/ChangeLog b/ChangeLog
index 3df0457039a97297f1e3d823b481a88e3ef658fb..63ffa486bc4b572ae3fb1ad3d0355013f9496fe7 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2008-07-12  Nicolas François  <nicolas.francois@centraliens.net>
+
+       * lib/gshadow.c: Avoid assignments in comparison.
+
 2008-07-12  Nicolas François  <nicolas.francois@centraliens.net>
 
        * ChangeLog, NEWS, src/login.c: Re-inject the changes from 4.1.2.1.

diff --git a/lib/gshadow.c b/lib/gshadow.c
index 6f5a3d91d3cf8b99652c197ee88af2c9106de5fd..202cad3a8cc3bddedb3730a51f91491d80c93549 100644 (file)
--- a/lib/gshadow.c
+++ b/lib/gshadow.c
@@ -86,7 +86,8 @@ static char **build_list (char *s, char **list[], size_t * nlist)
 
        while (s != NULL && *s != '\0') {
                size = (nelem + 1) * sizeof (ptr);
-               if ((ptr = realloc (*list, size)) != NULL) {
+               ptr = realloc (*list, size);
+               if (NULL != ptr) {
                        ptr[nelem] = s;
                        nelem++;
                        *list = ptr;