Promote warning to exception in dns_check_record() function

GH-5004

diff --git a/ext/standard/dns.c b/ext/standard/dns.c
index c3a9b9cde66ab4765a764f1ed28d1733353d5225..d46226aafd1d3767e05a15d07cc6b52407075951 100644 (file)
--- a/ext/standard/dns.c
+++ b/ext/standard/dns.c
@@ -383,8 +383,8 @@ PHP_FUNCTION(dns_check_record)
        ZEND_PARSE_PARAMETERS_END();
 
        if (hostname_len == 0) {
-               php_error_docref(NULL, E_WARNING, "Host cannot be empty");
-               RETURN_FALSE;
+               zend_value_error("Host cannot be empty");
+               return;
        }
 
        if (rectype) {

diff --git a/ext/standard/dns_win32.c b/ext/standard/dns_win32.c
index 5dc39a104ba0a24dc7e230b2a1492c6176dfabd1..1221cbb6fb77bbdecd5cadf674804764d60cf781 100644 (file)
--- a/ext/standard/dns_win32.c
+++ b/ext/standard/dns_win32.c
@@ -107,8 +107,8 @@ PHP_FUNCTION(dns_check_record)
        }
 
        if (hostname_len == 0) {
-               php_error_docref(NULL, E_WARNING, "Host cannot be empty");
-               RETURN_FALSE;
+               zend_value_error("Host cannot be empty");
+               return;
        }
 
        if (rectype) {

diff --git a/ext/standard/tests/network/bug41347.phpt b/ext/standard/tests/network/bug41347.phpt
index 6ece098191de51fc0567b3a4eb65569eeb698c21..6390327a52bef24d59262e2cecb1857b902aeb7b 100644 (file)
--- a/ext/standard/tests/network/bug41347.phpt
+++ b/ext/standard/tests/network/bug41347.phpt
@@ -2,8 +2,11 @@
 dns_check_record() segfault with empty host
 --FILE--
 <?php
-var_dump(dns_check_record(''));
+try {
+    var_dump(dns_check_record(''));
+} catch (ValueError $exception) {
+    echo $exception->getMessage() . "\n";
+}
 ?>
---EXPECTF--
-Warning: dns_check_record(): Host cannot be empty in %s on line %d
-bool(false)
+--EXPECT--
+Host cannot be empty