Instead of using the poor system rand() algorithm and the

system-time seed, rely on the long-living LCG to determine
whether to start the GC process.

diff --git a/ext/session/session.c b/ext/session/session.c
index 1248e6e02dd9ed245fb0d2beb23832dacacaf834..f709b6be2bf449e022b404711ce2299a020d4466 100644 (file)
--- a/ext/session/session.c
+++ b/ext/session/session.c
@@ -911,9 +911,8 @@ static void php_session_start(PSLS_D)
        if (PS(mod_data) && PS(gc_probability) > 0) {
                int nrdels = -1;
 
-               srand(time(NULL));
-               nrand = (int) (100.0*rand()/RAND_MAX);
-               if (nrand < PS(gc_probability)) {
+               nrand = (int) (100.0*php_combined_lcg());
+               if (nrand <= PS(gc_probability)) {
                        PS(mod)->gc(&PS(mod_data), PS(gc_maxlifetime), &nrdels);
 #if 0
                        if (nrdels != -1)