]> granicus.if.org Git - pdns/commitdiff
Update pdns/Makefile.am: make curl report error on failure
authorBas van Schaik <sjvs@users.noreply.github.com>
Wed, 16 Mar 2016 10:33:51 +0000 (10:33 +0000)
committerBas van Schaik <sjvs@users.noreply.github.com>
Wed, 16 Mar 2016 10:33:51 +0000 (10:33 +0000)
By default 'curl -s' (for silent) will swallow any errors that occur during the retrieval of the URL. This makes problems rather difficult to debug. The '-S' flag changes this behaviour: "When used with -s it makes curl show an error message if it fails" (from the manpage)

pdns/Makefile.am

index cb67d3bb5eae0059be3b4d00d4d8dec8919a0473..b2ab32b468503a4e36e8e4f5d6e33e25c23563bc 100644 (file)
@@ -1115,7 +1115,7 @@ curl_verbose = $(curl_verbose_$(V))
 curl_verbose_ = $(curl_verbose_$(AM_DEFAULT_VERBOSITY))
 curl_verbose_0 = @echo "  CURL    " $@;
 $(srcdir)/effective_tld_names.dat:
-       $(curl_verbose)if ! curl -s https://publicsuffix.org/list/public_suffix_list.dat > $@; then rm -f $@; exit 1; fi
+       $(curl_verbose)if ! curl -s -S https://publicsuffix.org/list/public_suffix_list.dat > $@; then rm -f $@; exit 1; fi
 
 pubsuffix.cc: $(srcdir)/effective_tld_names.dat
        $(AM_V_GEN)./mkpubsuffixcc