Refactoring / code cleanup.

See:

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.

diff --git a/fortune-mod/datfiles/data/rules-of-acquisition-gen.sh b/fortune-mod/datfiles/data/rules-of-acquisition-gen.sh
index c26233761735d817c48346bd5389748711d00270..bf6a5b1ff9b671b04f2fe908f7f599294b188815 100644 (file)
--- a/fortune-mod/datfiles/data/rules-of-acquisition-gen.sh
+++ b/fortune-mod/datfiles/data/rules-of-acquisition-gen.sh
@@ -29,8 +29,6 @@ fi
 # Convert CSV to DAT + wrap long lines + remove trailing whitespace
 while IFS="${csv_delimiter}" read -r number rule source
 do
-       printf -- "${title_template}\n" "${number}"
-       printf -- "${rule_template}\n" "${rule}"
-       printf -- "${source_template}\n" "${source}"
-       printf -- "${footer_template}\n"
+       printf -- "${title_template}\\n${rule_template}\\n${source_template}\\n${footer_template}\\n" \
+        "${number}" "${rule}" "${source}"
 done < "${infile}" | fold -sw "${line_maxlen}" | sed -e 's/[[:space:]]*$//' > "${outfile}"