Revert "Fix potential fd leak in listener_read_cb()"

This reverts commit a695a720cda892c270736d127333d73553842094.

@kgraefe:
  "I believe that this commit is just wrong: if lev->cnt is not 1 after
  the callback, new_fd will still never be closed in listener_read_cb().
  So in that case it is the responsibility of the user's code to close
  the file descriptor (which is fine). But why shouldn't it be in the
  other case? And how does the user's code know?"

And I agree

diff --git a/listener.c b/listener.c
index 2862d32e38d0335c218e7ce8defc23a7911a8126..942fa45180f957fd4a6b751c21d8792cc5ce9d43 100644 (file)
--- a/listener.c
+++ b/listener.c
@@ -421,8 +421,6 @@ listener_read_cb(evutil_socket_t fd, short what, void *p)
                if (lev->refcnt == 1) {
                        int freed = listener_decref_and_unlock(lev);
                        EVUTIL_ASSERT(freed);
-
-                       evutil_closesocket(new_fd);
                        return;
                }
                --lev->refcnt;