Fix NTLM authentication memory leak on SSPI enabled Windows builds

diff --git a/CHANGES b/CHANGES
index 8176b8a29501a7a97260b7f429b7bd3da44fdc95..57e7eec5dcbefc947f8852d38caae55a314c33e2 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -6,6 +6,10 @@
 
                                   Changelog
 
+Yang Tse (5 Mar 2009)
+- Fixed NTLM authentication memory leak on SSPI enabled Windows builds. This
+  issue was noticed by Chris Deidun.
+
 Daniel Fandrich (4 Mar 2009)
 - Fixed a problem with m4 quoting in the OpenSSL configure check reported
   by Daniel Johnson.

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 2dc9daf81f6fa2e43d9223e082157f07dac8e4c6..4398cce85a30dc66d238d57ad37f68c63fdc977a 100644 (file)
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -14,7 +14,7 @@ This release includes the following changes:
 
 This release includes the following bugfixes:
 
- o 
+ o NTLM authentication memory leak on SSPI enabled Windows builds
 
 This release includes the following known bugs:
 
@@ -23,6 +23,6 @@ This release includes the following known bugs:
 This release would not have looked like this without help, code, reports and
 advice from friends like these:
 
- David James
+ David James, Chris Deidun
 
         Thanks! (and sorry if I forgot to mention someone)

diff --git a/lib/http_ntlm.c b/lib/http_ntlm.c
index 9742e196df8614e911fe87f2a6482eb32453de71..e1141f3104b70bccce50465b9fceb1b9bf17627a 100644 (file)
--- a/lib/http_ntlm.c
+++ b/lib/http_ntlm.c
@@ -303,9 +303,8 @@ CURLntlm Curl_input_ntlm(struct connectdata *conn,
         fprintf(stderr, "\n****\n");
         fprintf(stderr, "**** Header %s\n ", header);
       });
-
-      free(buffer);
 #endif
+      free(buffer);
     }
     else {
       if(ntlm->state >= NTLMSTATE_TYPE1)