]> granicus.if.org Git - libevent/commitdiff
Fix bufferevent_get_{openssl,mbedtls}_error()
authorAzat Khuzhin <azat@libevent.org>
Thu, 23 Jul 2020 20:38:53 +0000 (23:38 +0300)
committerAzat Khuzhin <azat@libevent.org>
Thu, 23 Jul 2020 20:41:31 +0000 (23:41 +0300)
The bufferevent_get_openssl_error() returns unsigned long, so returning
-1 on error in unclear. Let's use 0.

Fixes: #1028
bufferevent_mbedtls.c
bufferevent_openssl.c

index c60b109c587d32256a3953b9f3ce23de7700d755..1b59a5322590ac4096bf540b0125dfc1ec30da67 100644 (file)
@@ -290,7 +290,7 @@ bufferevent_get_mbedtls_error(struct bufferevent *bufev)
 {
        struct bufferevent_ssl *bev_ssl = bufferevent_ssl_upcast(bufev);
        if (!bev_ssl)
-               return -1;
+               return 0;
        return bufferevent_get_ssl_error(bufev);
 }
 
index c50c022dc59f20b876bf5a5eab92059af4eb480a..2fb6c2527d75b29ab27a4c0587c1cec3534ebeff 100644 (file)
@@ -524,6 +524,6 @@ bufferevent_get_openssl_error(struct bufferevent *bufev)
 {
        struct bufferevent_ssl *bev_ssl = bufferevent_ssl_upcast(bufev);
        if (!bev_ssl)
-               return -1;
+               return 0;
        return bufferevent_get_ssl_error(bufev);
 }