]> granicus.if.org Git - apache/commitdiff
mpm_winnt: Remove an unnecessary retry after receiving a non-timeout failure
authorEvgeny Kotkov <kotkov@apache.org>
Fri, 7 Jul 2017 11:08:26 +0000 (11:08 +0000)
committerEvgeny Kotkov <kotkov@apache.org>
Fri, 7 Jul 2017 11:08:26 +0000 (11:08 +0000)
from the mpm_get_completion_context() function.

Currently, the only possible reasons why mpm_get_completion_context() could
fail are real errors such as being unable to WaitForSingleObject(), allocate
memory or create an event.  Retrying under such circumstances doesn't make
sense, and could be as well considered harmful.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1801146 13f79535-47bb-0310-9956-ffa450edef68

server/mpm/winnt/child.c

index cf94378f068b3ade4d31178e04d5e3c5d08964a2..c891a1a6f5830e8e818b6126c6b5792d436a27c7 100644 (file)
@@ -438,14 +438,7 @@ reinit: /* target of connect upon too many AcceptEx failures */
             context = mpm_get_completion_context(&timeout);
             if (!context) {
                 if (!timeout) {
-                    /* Hopefully a temporary condition in the provider? */
-                    ++err_count;
-                    if (err_count > MAX_ACCEPTEX_ERR_COUNT) {
-                        ap_log_error(APLOG_MARK, APLOG_CRIT, 0, ap_server_conf, APLOGNO(00335)
-                                     "winnt_accept: Too many failures grabbing a "
-                                     "connection ctx.  Aborting.");
-                        break;
-                    }
+                    break;
                 }
                 Sleep(100);
                 continue;