]> granicus.if.org Git - graphviz/commitdiff
GTK plugin: squash -Wsign-conversion warnings for 'GdkEventButton' values
authorMatthew Fernandez <matthew.fernandez@gmail.com>
Mon, 5 Sep 2022 17:25:59 +0000 (10:25 -0700)
committerMatthew Fernandez <matthew.fernandez@gmail.com>
Sat, 10 Sep 2022 19:01:11 +0000 (12:01 -0700)
The GDK API documents these events as coming from an enum, all of whose values
fit in an int.

plugin/gtk/callbacks.c

index d601e79771fc008e2a035fad3820b622c438cae4..fa3bc4c49ee7f8c1861c451f681437391b4aeb5e 100644 (file)
@@ -11,6 +11,7 @@
 #include "config.h"
 #include <assert.h>
 #include <gtk/gtk.h>
+#include <limits.h>
 #include <stdbool.h>
 
 #include <gvc/gvplugin_device.h>
@@ -381,7 +382,8 @@ on_drawingarea1_button_press_event     (GtkWidget       *widget,
     GVJ_t *job = g_object_get_data(G_OBJECT(widget),"job");
     pointer.x = event->x;
     pointer.y = event->y;
-    (job->callbacks->button_press)(job, event->button, pointer);
+    assert(event->button <= INT_MAX);
+    (job->callbacks->button_press)(job, (int)event->button, pointer);
     
     load_store_with_attrs(GTK_LIST_STORE(g_object_get_data(G_OBJECT(widget), "attr_store")));
     return FALSE;
@@ -400,7 +402,8 @@ on_drawingarea1_button_release_event   (GtkWidget       *widget,
     GVJ_t *job = g_object_get_data(G_OBJECT(widget),"job");
     pointer.x = event->x;
     pointer.y = event->y;
-    (job->callbacks->button_release)(job, event->button, pointer);
+    assert(event->button <= INT_MAX);
+    (job->callbacks->button_release)(job, (int)event->button, pointer);
 
     return FALSE;
 }