]> granicus.if.org Git - python/commitdiff
Fixes issue #9535: Fix pending signals that have been received but not
authorGregory P. Smith <greg@krypto.org>
Sun, 11 Nov 2012 04:33:07 +0000 (20:33 -0800)
committerGregory P. Smith <greg@krypto.org>
Sun, 11 Nov 2012 04:33:07 +0000 (20:33 -0800)
yet handled by Python to not persist after os.fork() in the child process.

Misc/NEWS
Modules/signalmodule.c

index ab18f032c5abad74e0a0a1d68ccb4b7ec3565a60..6a97cbcf8ad635239caa9997d447f6869d35308f 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -10,6 +10,9 @@ What's New in Python 3.2.4
 Core and Builtins
 -----------------
 
+- Issue #9535: Fix pending signals that have been received but not yet
+  handled by Python to not persist after os.fork() in the child process.
+
 - Issue #15001: fix segfault on "del sys.module['__main__']". Patch by Victor
   Stinner.
 
index 32cd8bbece1fe0399e984e0841a87ce0d5b75c73..9cae454194a3d4ddca15cace75890e7a1ce4dbfc 100644 (file)
@@ -987,9 +987,25 @@ PyOS_InterruptOccurred(void)
     return 0;
 }
 
+static void
+_clear_pending_signals(void)
+{
+    int i;
+    if (!is_tripped)
+        return;
+    is_tripped = 0;
+    for (i = 1; i < NSIG; ++i) {
+        Handlers[i].tripped = 0;
+    }
+}
+
 void
 PyOS_AfterFork(void)
 {
+    /* Clear the signal flags after forking so that they aren't handled
+     * in both processes if they came in just before the fork() but before
+     * the interpreter had an opportunity to call the handlers.  issue9535. */
+    _clear_pending_signals();
 #ifdef WITH_THREAD
     /* PyThread_ReInitTLS() must be called early, to make sure that the TLS API
      * can be called safely. */