]> granicus.if.org Git - php/commitdiff
Remove conditional calls of always available macros
authorPeter Kokot <peterkokot@gmail.com>
Sun, 14 Jul 2019 20:24:21 +0000 (22:24 +0200)
committerPeter Kokot <peterkokot@gmail.com>
Sun, 14 Jul 2019 20:24:21 +0000 (22:24 +0200)
These checks were once relevant for these extensions in PECL and PHP
versions without availability of the checked macros.

Closes GH-4405

ext/hash/config.m4
ext/pdo/config.m4
ext/pdo_dblib/config.m4
ext/pdo_oci/config.m4
ext/pdo_odbc/config.m4
ext/pdo_pgsql/config.m4
ext/pdo_sqlite/config.m4

index 0fa45265013d42326ec14e972b6190a11298e0a5..111574e749bb9827f1ebbd0aa74d9289da4ac8b0 100644 (file)
@@ -45,6 +45,4 @@ EXT_HASH_HEADERS="php_hash.h php_hash_md.h php_hash_sha.h php_hash_ripemd.h \
   php_hash_fnv.h php_hash_joaat.h php_hash_sha3.h"
 
 PHP_NEW_EXTENSION(hash, $EXT_HASH_SOURCES, 0,,$PHP_HASH_CFLAGS)
-ifdef([PHP_INSTALL_HEADERS], [
-       PHP_INSTALL_HEADERS(ext/hash, $EXT_HASH_HEADERS)
-])
+PHP_INSTALL_HEADERS(ext/hash, $EXT_HASH_HEADERS)
index b8e6f4e12930ea59a2d5d62a2221d4d706d643a1..9b9a3e36df7afd5a7f378d77eb16ad7aa82c02a3 100644 (file)
@@ -10,16 +10,8 @@ if test "$PHP_PDO" != "no"; then
   PHP_PDO=yes
 
   PHP_NEW_EXTENSION(pdo, pdo.c pdo_dbh.c pdo_stmt.c pdo_sql_parser.c pdo_sqlstate.c, $ext_shared)
-  ifdef([PHP_ADD_EXTENSION_DEP],
-  [
-    PHP_ADD_EXTENSION_DEP(pdo, spl, true)
-  ])
-
-  ifdef([PHP_INSTALL_HEADERS],
-  [
-    dnl Sadly, this is a complete NOP for pecl extensions
-    PHP_INSTALL_HEADERS(ext/pdo, [php_pdo.h php_pdo_driver.h php_pdo_error.h])
-  ])
+  PHP_ADD_EXTENSION_DEP(pdo, spl, true)
+  PHP_INSTALL_HEADERS(ext/pdo, [php_pdo.h php_pdo_driver.h php_pdo_error.h])
 
   dnl so we always include the known-good working hack.
   PHP_ADD_MAKEFILE_FRAGMENT
index fe81dd8031c3dd5b805f0ca0df29051e44bd42c2..880baf9472cd7ab383c7bd52718074e282b1a49f 100644 (file)
@@ -63,8 +63,5 @@ if test "$PHP_PDO_DBLIB" != "no"; then
   AC_DEFINE(HAVE_FREETDS,1,[ ])
   PHP_SUBST(PDO_DBLIB_SHARED_LIBADD)
 
-  ifdef([PHP_ADD_EXTENSION_DEP],
-  [
-    PHP_ADD_EXTENSION_DEP(pdo_dblib, pdo)
-  ])
+  PHP_ADD_EXTENSION_DEP(pdo_dblib, pdo)
 fi
index fe0fecddd6af010fe458007bd0f4d708cbc14a74..ab8c7bfa660058c85b7ab7c16cdf6a45a92df1bf 100644 (file)
@@ -218,10 +218,7 @@ if test "$PHP_PDO_OCI" != "no"; then
   PHP_SUBST_OLD(PDO_OCI_DIR)
   PHP_SUBST_OLD(PDO_OCI_VERSION)
 
-  ifdef([PHP_ADD_EXTENSION_DEP],
-  [
-    PHP_ADD_EXTENSION_DEP(pdo_oci, pdo)
-  ])
+  PHP_ADD_EXTENSION_DEP(pdo_oci, pdo)
 
   AC_DEFINE_UNQUOTED(PHP_PDO_OCI_CLIENT_VERSION, "$PDO_OCI_VERSION", [ ])
 fi
index 9532a8d4d8e51c456287151342e83225e21d8809..72b604199bf722511c099e50446111a907e29980 100644 (file)
@@ -140,8 +140,5 @@ functions required for PDO support.
 
   PHP_NEW_EXTENSION(pdo_odbc, pdo_odbc.c odbc_driver.c odbc_stmt.c, $ext_shared,,-I$pdo_cv_inc_path $PDO_ODBC_INCLUDE)
   PHP_SUBST(PDO_ODBC_SHARED_LIBADD)
-  ifdef([PHP_ADD_EXTENSION_DEP],
-  [
-    PHP_ADD_EXTENSION_DEP(pdo_odbc, pdo)
-  ])
+  PHP_ADD_EXTENSION_DEP(pdo_odbc, pdo)
 fi
index e0c2df24f22fc7f51edef4bb2dd1a65501d5b569..7655357de4f1aa4ad14d89dd388e174ddd591888 100644 (file)
@@ -86,8 +86,5 @@ if test "$PHP_PDO_PGSQL" != "no"; then
   PHP_CHECK_PDO_INCLUDES
 
   PHP_NEW_EXTENSION(pdo_pgsql, pdo_pgsql.c pgsql_driver.c pgsql_statement.c, $ext_shared,,-I$pdo_cv_inc_path)
-  ifdef([PHP_ADD_EXTENSION_DEP],
-  [
-    PHP_ADD_EXTENSION_DEP(pdo_pgsql, pdo)
-  ])
+  PHP_ADD_EXTENSION_DEP(pdo_pgsql, pdo)
 fi
index c45d73f526205286552ae9b290a7b83f290a6e4f..873dd36544a340d8ab5e024f9e457d455f17969c 100644 (file)
@@ -42,8 +42,5 @@ if test "$PHP_PDO_SQLITE" != "no"; then
   dnl Solaris fix
   PHP_CHECK_LIBRARY(rt, fdatasync, [PHP_ADD_LIBRARY(rt,, PDO_SQLITE_SHARED_LIBADD)])
 
-  ifdef([PHP_ADD_EXTENSION_DEP],
-  [
-    PHP_ADD_EXTENSION_DEP(pdo_sqlite, pdo)
-  ])
+  PHP_ADD_EXTENSION_DEP(pdo_sqlite, pdo)
 fi