Split this test up to a 64bit version for more coverage

The 32bit version does not have the 64bit float values here, we already have 3 float tests which I guess will do for now at least

diff --git a/ext/exif/tests/exif_tagname_variation1-64bit.phpt b/ext/exif/tests/exif_tagname_variation1-64bit.phpt
new file mode 100644 (file)
index 0000000..22298af
--- /dev/null
+++ b/ext/exif/tests/exif_tagname_variation1-64bit.phpt
@@ -0,0 +1,183 @@
+--TEST--
+Test exif_tagname() function : usage variations  - different types for index argument
+--SKIPIF--
+<?php if (!extension_loaded('exif')) print 'skip exif extension not available';
+if (PHP_INT_SIZE != 8) die('skip 64-bit only');
+?>
+--FILE--
+<?php
+
+/* Prototype  : string exif_tagname ( string $index  )
+ * Description: Get the header name for an index
+ * Source code: ext/exif/exif.c
+*/
+
+echo "*** Testing exif_tagname() : different types for index argument ***\n";
+// initialize all required variables
+
+// get an unset variable
+$unset_var = 'string_val';
+unset($unset_var);
+
+// declaring a class
+class sample  {
+  public function __toString() {
+  return "obj'ct";
+  } 
+}
+
+// Defining resource
+$file_handle = fopen(__FILE__, 'r');
+
+// array with different values
+$values =  array (
+
+  // integer values
+  0,
+  1,
+  12345,
+  -2345,
+
+  // float values
+  10.5,
+  -10.5,
+  10.1234567e10,
+  10.7654321E-10,
+  .5,
+
+  // array values
+  array(),
+  array(0),
+  array(1),
+  array(1, 2),
+  array('color' => 'red', 'item' => 'pen'),
+
+  // boolean values
+  true,
+  false,
+  TRUE,
+  FALSE,
+
+  // empty string
+  "",
+  '',
+
+  // undefined variable
+  $undefined_var,
+
+  // unset variable
+  $unset_var,
+  
+  // objects
+  new sample(),
+
+  // resource
+  $file_handle,
+ 
+  NULL,
+  null
+);
+
+
+// loop through each element of the array and check the working of exif_tagname()
+// when $index argument is supplied with different values
+
+echo "\n--- Testing exif_tagname() by supplying different values for 'index' argument ---\n";
+$counter = 1;
+foreach($values as $index) {
+  echo "-- Iteration $counter --\n";
+  var_dump( exif_tagname($index) );
+  $counter ++;
+}
+
+// closing the file
+fclose($file_handle);
+
+echo "Done\n";
+?>
+
+?>
+===Done===
+--EXPECTF--
+*** Testing exif_tagname() : different types for index argument ***
+
+Notice: Undefined variable: undefined_var in %s on line %d
+
+Notice: Undefined variable: unset_var in %s on line %d
+
+--- Testing exif_tagname() by supplying different values for 'index' argument ---
+-- Iteration 1 --
+bool(false)
+-- Iteration 2 --
+bool(false)
+-- Iteration 3 --
+bool(false)
+-- Iteration 4 --
+bool(false)
+-- Iteration 5 --
+bool(false)
+-- Iteration 6 --
+bool(false)
+-- Iteration 7 --
+bool(false)
+-- Iteration 8 --
+bool(false)
+-- Iteration 9 --
+bool(false)
+-- Iteration 10 --
+
+Warning: exif_tagname() expects parameter 1 to be integer, array given in %s on line %d
+NULL
+-- Iteration 11 --
+
+Warning: exif_tagname() expects parameter 1 to be integer, array given in %s on line %d
+NULL
+-- Iteration 12 --
+
+Warning: exif_tagname() expects parameter 1 to be integer, array given in %s on line %d
+NULL
+-- Iteration 13 --
+
+Warning: exif_tagname() expects parameter 1 to be integer, array given in %s on line %d
+NULL
+-- Iteration 14 --
+
+Warning: exif_tagname() expects parameter 1 to be integer, array given in %s on line %d
+NULL
+-- Iteration 15 --
+bool(false)
+-- Iteration 16 --
+bool(false)
+-- Iteration 17 --
+bool(false)
+-- Iteration 18 --
+bool(false)
+-- Iteration 19 --
+
+Warning: exif_tagname() expects parameter 1 to be integer, string given in %s on line %d
+NULL
+-- Iteration 20 --
+
+Warning: exif_tagname() expects parameter 1 to be integer, string given in %s on line %d
+NULL
+-- Iteration 21 --
+bool(false)
+-- Iteration 22 --
+bool(false)
+-- Iteration 23 --
+
+Warning: exif_tagname() expects parameter 1 to be integer, object given in %s on line %d
+NULL
+-- Iteration 24 --
+
+Warning: exif_tagname() expects parameter 1 to be integer, resource given in %s on line %d
+NULL
+-- Iteration 25 --
+bool(false)
+-- Iteration 26 --
+bool(false)
+Done
+
+?>
+===Done===
+

diff --git a/ext/exif/tests/exif_tagname_variation1.phpt b/ext/exif/tests/exif_tagname_variation1.phpt
index 22298af2ae55c527a120ecbce289c2885ec9ac71..44d2568f4961c446a7969babb5626edd87176eee 100644 (file)
--- a/ext/exif/tests/exif_tagname_variation1.phpt
+++ b/ext/exif/tests/exif_tagname_variation1.phpt
@@ -2,7 +2,7 @@
 Test exif_tagname() function : usage variations  - different types for index argument
 --SKIPIF--
 <?php if (!extension_loaded('exif')) print 'skip exif extension not available';
-if (PHP_INT_SIZE != 8) die('skip 64-bit only');
+if (PHP_INT_SIZE != 4) die('skip 32-bit only');
 ?>
 --FILE--
 <?php
@@ -41,8 +41,6 @@ $values =  array (
   // float values
   10.5,
   -10.5,
-  10.1234567e10,
-  10.7654321E-10,
   .5,
 
   // array values
@@ -121,60 +119,56 @@ bool(false)
 -- Iteration 7 --
 bool(false)
 -- Iteration 8 --
-bool(false)
--- Iteration 9 --
-bool(false)
--- Iteration 10 --
 
 Warning: exif_tagname() expects parameter 1 to be integer, array given in %s on line %d
 NULL
--- Iteration 11 --
+-- Iteration 9 --
 
 Warning: exif_tagname() expects parameter 1 to be integer, array given in %s on line %d
 NULL
--- Iteration 12 --
+-- Iteration 10 --
 
 Warning: exif_tagname() expects parameter 1 to be integer, array given in %s on line %d
 NULL
--- Iteration 13 --
+-- Iteration 11 --
 
 Warning: exif_tagname() expects parameter 1 to be integer, array given in %s on line %d
 NULL
--- Iteration 14 --
+-- Iteration 12 --
 
 Warning: exif_tagname() expects parameter 1 to be integer, array given in %s on line %d
 NULL
+-- Iteration 13 --
+bool(false)
+-- Iteration 14 --
+bool(false)
 -- Iteration 15 --
 bool(false)
 -- Iteration 16 --
 bool(false)
 -- Iteration 17 --
-bool(false)
--- Iteration 18 --
-bool(false)
--- Iteration 19 --
 
 Warning: exif_tagname() expects parameter 1 to be integer, string given in %s on line %d
 NULL
--- Iteration 20 --
+-- Iteration 18 --
 
 Warning: exif_tagname() expects parameter 1 to be integer, string given in %s on line %d
 NULL
--- Iteration 21 --
+-- Iteration 19 --
 bool(false)
--- Iteration 22 --
+-- Iteration 20 --
 bool(false)
--- Iteration 23 --
+-- Iteration 21 --
 
 Warning: exif_tagname() expects parameter 1 to be integer, object given in %s on line %d
 NULL
--- Iteration 24 --
+-- Iteration 22 --
 
 Warning: exif_tagname() expects parameter 1 to be integer, resource given in %s on line %d
 NULL
--- Iteration 25 --
+-- Iteration 23 --
 bool(false)
--- Iteration 26 --
+-- Iteration 24 --
 bool(false)
 Done