]> granicus.if.org Git - clang/commitdiff
[CMake] Don't set Python_ADDITIONAL_VERSIONS
authorJonas Devlieghere <jonas@devlieghere.com>
Thu, 18 Jul 2019 15:17:42 +0000 (15:17 +0000)
committerJonas Devlieghere <jonas@devlieghere.com>
Thu, 18 Jul 2019 15:17:42 +0000 (15:17 +0000)
Until recently, Python_ADDITIONAL_VERSIONS was used to limit LLVM's
Python support to 2.7. Now that both LLVM and LLDB both support Python
3, there's no longer a need to put an arbitrary limit on this.

However, instead of removing the variable, r365692 expanded the list,
which has the (presumably unintentional) side-effect of expression
preference for Python 3.

Instead, as Michal proposed in the original code review, we should just
not set the list at all, and let CMake pick whatever Python interpreter
you have in your path.

This patch removes the Python_ADDITIONAL_VERSIONS variable in llvm,
clang and lld. I've also updated the docs with the default behavior and
how to force a different Python version to be used.

Differential revision: https://reviews.llvm.org/D64894

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@366447 91177308-0d34-0410-b5e6-96231b3b80d8

CMakeLists.txt

index 6cf28d8cbbb48cd38ba9760db5aba793475d7589..60937aa9db380ed443b816645e46585976fc79b8 100644 (file)
@@ -129,7 +129,6 @@ if( CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR )
   set( CMAKE_ARCHIVE_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/lib${LLVM_LIBDIR_SUFFIX} )
 
   if(LLVM_INCLUDE_TESTS)
-    set(Python_ADDITIONAL_VERSIONS 2.7)
     include(FindPythonInterp)
     if(NOT PYTHONINTERP_FOUND)
       message(FATAL_ERROR